Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Production/GFS.v16: update WW3 component to write indicator log file for gridded output #2594

Conversation

MatthewMasarik-NOAA
Copy link
Collaborator

@MatthewMasarik-NOAA MatthewMasarik-NOAA commented Feb 6, 2025

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

This PR makes a small update contained within the WW3 component. The update allows WW3 to produce an indicator log file while writing gridded output to disk. For each grid and timestep, an indicator file will be created only once the writing of the gridded output has finished. The indicator file will have the same name as the associated gridded file with the exception that it has
.FINISHED appended as a suffix. This log file is an empty plain text file.

Commit Message:

  * WW3 - add indicator log file write for gridded output 

Priority:

  • High: Fix for production/GFS.v16

Git Tracking

UFSWM:

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • None

Changes

Regression Test Changes (Please commit test_changes.list):

  • No Baseline Changes.

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • GaeaC5
    • GaeaC6
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@MatthewMasarik-NOAA MatthewMasarik-NOAA marked this pull request as ready for review February 10, 2025 15:19
Copy link
Collaborator

@JessicaMeixner-NOAA JessicaMeixner-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was tested in the global-workflow.

@JessicaMeixner-NOAA
Copy link
Collaborator

@BrianCurtis-NOAA: This production update is ready for merging and then we will need a tag GFS.v16.4.0

Please let me know if you have any questions/comments/concerns.

@BrianCurtis-NOAA
Copy link
Collaborator

@JessicaMeixner-NOAA it's on my to do for tomorrow

@BrianCurtis-NOAA
Copy link
Collaborator

It looks like there's only one change with WW3 which i've confirmed the hashes match. Testing was mentioned as completed. I'll merge and create tag GFS.v16.4.0

@BrianCurtis-NOAA BrianCurtis-NOAA merged commit 9bd8d2c into ufs-community:production/GFS.v16 Feb 11, 2025
1 check failed
@MatthewMasarik-NOAA
Copy link
Collaborator Author

It looks like there's only one change with WW3 which i've confirmed the hashes match. Testing was mentioned as completed. I'll merge and create tag GFS.v16.4.0

Awesome. Thank you @BrianCurtis-NOAA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants