Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rotation.py #133

Merged
merged 2 commits into from
Feb 12, 2025
Merged

Update rotation.py #133

merged 2 commits into from
Feb 12, 2025

Conversation

TobiBu
Copy link
Collaborator

@TobiBu TobiBu commented Feb 5, 2025

remove unused keyword argument type

remove unused keyword argument type
remove the keyword arg also in pipeline.yaml
@TobiBu
Copy link
Collaborator Author

TobiBu commented Feb 6, 2025

while creating this cosmetic patch i also realised, that we can't easily change the rotation in the yaml beyond face-on and edge-on, right? How does @nihatog achieve this?

@nihatog
Copy link
Collaborator

nihatog commented Feb 6, 2025

We can set any rotation beyond face-on and edge-on by directly setting alpha, beta and gamma in the config. So it would look like this for example:

config = {
    "pipeline": {"name": "calc_ifu"},
    "galaxy": {
        "dist_z": 0.1,
        "rotation": {
            "alpha": 45.0, 
            "beta": 30.0,  
            "gamma": 90.0 
        },
    },
    #....
}

@ufuk-cakir ufuk-cakir self-requested a review February 11, 2025 16:15
@nihatog nihatog merged commit 8360b2b into main Feb 12, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants