This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
remove unnecessary dependencies, fix the bug that got the header of t… #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oken instead of the payload
kjellp
reviewed
Feb 15, 2024
There was a problem hiding this comment.
Should the variable names be updated here? Are we picking a body of the token by purpose and process it in variables with names referring to Header ?
There was a problem hiding this comment.
No varibale names are ok. before changing libraries the code used getClaims() on the JWT(whole of it) and the result contained all the claims in the token. then after replacing the new code by mistake the first part of the token was decoded which is the header not the payload that has the claims (in this case "sub" was the part that gave null pointer exception)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…oken instead of the payload
Describe the pull request:
Pull request long description:
Related issues:
Additional information: