Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Add an endpoint to return TSD Token #55

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Conversation

a-ghanem
Copy link
Contributor

Describe the pull request:

  • Functional change

Pull request long description:

Added a new REST API endpoint to return a TSD token.

@a-ghanem a-ghanem requested review from opsdep and kjellp February 16, 2022 10:42
@a-ghanem a-ghanem changed the title Add a method to return TSD Token Add an endpoint to return TSD Token Feb 16, 2022
@a-ghanem a-ghanem force-pushed the feature/get-tsd-token branch from 193507a to ddf76b4 Compare February 16, 2022 10:44
@kjellp
Copy link
Contributor

kjellp commented Jan 23, 2024

@joshbaskaran do you think this PR is possible to get updated, reviewed and merged relatively quickly, or do you foreseen some trouble here? It would possibly speed up uploads quite a bit, and maybe get us beyound the 2hrs token expiry problem we're facing currently.

@joshbaskaran
Copy link
Contributor

joshbaskaran commented Jan 23, 2024

@kjellp
I would prefer to change the end-point to /tsd/token instead.
Other than that I'm quite sure how this would resolve a token expiry issue. I would like some context here like who/what is consuming this end-point and how its used.

@kjellp
Copy link
Contributor

kjellp commented Jan 23, 2024

The name change of end-point should not be a show-stopper, only need to update our lega-commander code to use that instead (currently the -b option of upload command is using the gettoken endpoint of the proxy service.

After lc swaps the LS AAI token for a TSD token, that TSD token has a TTL of ~24 hrs instead of ~2 hrs for the LS AAI token. But we need to double check that this also holds for a folder upload with many files (and that not a LS AAI token based "init" communication with the proxy service is needed for each of the files in the folder upload).

And to enable this "direct TSD upload pattern" using the -b option and the gettoken endpoint, also requires a closer inspection of the resume functionality, that we don't immediately break that.... (it's working for individual files now (via proxy service uploads), but not for folders...)

@joshbaskaran
Copy link
Contributor

@kjellp
In that case, please feel free to merge the branch :)

@kjellp kjellp dismissed joshbaskaran’s stale review February 16, 2024 09:52

As in the comment earlier, we do the namechange in proxy end-point and lega-commander in sync (new card added by Parisa in the board)

@Parisa68
Copy link
Collaborator

@dependabot rebase

@Parisa68 Parisa68 merged commit e182e2b into master Feb 16, 2024
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants