-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validation not working (Umbraco.RadioButtonList, Toggle) #18268
Comments
Hi there @croban! Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better. We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.
We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
Thanks, @croban , I was able to reproduce it on v15.2.0 (15.3.0-rc.preview.79). |
@NguyenThuyLan thx, Yes, this is more of a philosophical question 😊. In my view, a radio button list essentially has three possible states:
Similarly, in the case of a toggle switch, the "initial state" is unchecked. In some scenarios, you may want to ensure that users consciously make a selection (required) rather than leaving it undefined. br |
Hi @croban intersting thoughts on the Mandatory aspect. I would say that a Mandatory Property would require the Toggle to be set to true. Cause the alternative would be a undefined state (as you describe), which we should represent in the UI, so it does not become a secret state that developers understand — in other words we would need to make it clear to the user that they haven't made a choice. But this then changes how it has worked previously, so to avoid moving any cheese(breaking things) it should only hold false or true value. But if you bring a good case for the three state approach we could make it possible. Maybe a new Property Editor, technically the name could be NullableToggle? Also notice how such toggle should be able to be unset to go back to the undefined/null state — such could properly be okay to only achieve via a Property Action. :-) |
Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)
15.3.2
Bug summary
Validation does not work with Umbraco.RadioButtonList or Toggle.
I could save the document type.
Umbraco version 15.3.2
Specifics
No response
Steps to reproduce
really?
Expected result / actual result
No response
This item has been added to our backlog AB#48880
The text was updated successfully, but these errors were encountered: