Skip to content

Umbraco.Decimal Property Editor: Add Default value (closes #21787) #23015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jonty-Schmidt wants to merge 3 commits into
base: main
Choose a base branch
from
+95 −3

Added a unit test for the decimal preset.

bf63d52
Select commit
Loading
Failed to load commit list.
Open

Umbraco.Decimal Property Editor: Add Default value (closes #21787) #23015

Added a unit test for the decimal preset.
bf63d52
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Code Health Review (main) failed Jun 1, 2026 in 1m 1s

CodeScene PR Check

Quality Gate Failed

Gates Failed
Enforce advisory code health rules (1 file with Complex Conditional)

Gates Passed
3 Quality Gates Passed

See analysis details in CodeScene

Reason for failure
Enforce advisory code health rules Violations Code Health Impact
decimal-property-value-preset.ts 1 advisory rule 10.00 → 9.69 Suppress

Quality Gate Profile: Clean Code Collective
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Conditional decimal-property-value-preset.ts: UmbDecimalPropertyValuePreset.parseConfiguredNumber

Annotations

Check warning on line 22 in src/Umbraco.Web.UI.Client/src/packages/property-editors/number/decimal-property-value-preset.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Code Health Review (main)

❌ New issue: Complex Conditional 

UmbDecimalPropertyValuePreset.parseConfiguredNumber has 1 complex conditionals with 2 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.
View more details on CodeScene Delta Analysis