Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(uui-card): text overflow when user name is too long #1036

Merged
merged 8 commits into from
Mar 14, 2025

Conversation

NguyenThuyLan
Copy link
Contributor

@NguyenThuyLan NguyenThuyLan commented Mar 6, 2025

Description

This PR fixes the issue umbraco/Umbraco-CMS#18535.
This PR also fixes overflow text for block cards and content cards.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

Screenshots (if appropriate)

Before:
image

After fixed:
image

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Copy link

github-actions bot commented Mar 6, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-1036.westeurope.azurestaticapps.net

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-1036.westeurope.azurestaticapps.net

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-1036.westeurope.azurestaticapps.net

@iOvergaard iOvergaard added the bug Something isn't working label Mar 14, 2025
@iOvergaard iOvergaard changed the title Fix issue text overflow when user name is too long fix: text overflow when user name is too long Mar 14, 2025
@iOvergaard iOvergaard changed the title fix: text overflow when user name is too long fix(uui-card): text overflow when user name is too long Mar 14, 2025
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-1036.westeurope.azurestaticapps.net

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-1036.westeurope.azurestaticapps.net

@iOvergaard iOvergaard enabled auto-merge (squash) March 14, 2025 09:13
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-1036.westeurope.azurestaticapps.net

@iOvergaard iOvergaard merged commit e18d793 into v1/contrib Mar 14, 2025
11 of 12 checks passed
@iOvergaard iOvergaard deleted the v1/fix-bug/username-overflow branch March 14, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants