Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(uui-color-picker): allow the value to be empty #842

Merged
merged 9 commits into from
Jul 10, 2024
Merged

feat(uui-color-picker): allow the value to be empty #842

merged 9 commits into from
Jul 10, 2024

Conversation

loivsen
Copy link
Contributor

@loivsen loivsen commented Jul 8, 2024 •
edited
Loading

Description

Allows the UUI Color picker to have an empty string as value. This shows up as fully transparent.
Deleting a picked color now sets the value to empty string.

Fixed an issue where when typing in a color manually in the input field it would not update the value.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

We dont want the color picker to automatically pick a color for us.

@loivsen loivsen marked this pull request as draft July 8, 2024 14:06
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-842.westeurope.azurestaticapps.net

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-842.westeurope.azurestaticapps.net

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-842.westeurope.azurestaticapps.net

@loivsen loivsen changed the title Bugfix: Allow the UUI Color Picker value to be undefined... Bugfix: Allow the UUI Color Picker value to be empty. Jul 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-842.westeurope.azurestaticapps.net

@loivsen loivsen marked this pull request as ready for review July 9, 2024 12:18
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-842.westeurope.azurestaticapps.net

@iOvergaard iOvergaard changed the title Bugfix: Allow the UUI Color Picker value to be empty. bug(uui-color-picker): allow the value to be empty Jul 9, 2024
@iOvergaard iOvergaard added bug Something isn't working feature Something we are looking to build and removed bug Something isn't working labels Jul 9, 2024
@iOvergaard iOvergaard changed the title bug(uui-color-picker): allow the value to be empty feat(uui-color-picker): allow the value to be empty Jul 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-842.westeurope.azurestaticapps.net

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-842.westeurope.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-842.westeurope.azurestaticapps.net

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-842.westeurope.azurestaticapps.net

@iOvergaard iOvergaard merged commit c45ac40 into v1/contrib Jul 10, 2024
10 of 11 checks passed
@iOvergaard iOvergaard deleted the bugfix/allow-uui-color-picker-value-to-be-undefined branch July 10, 2024 11:04
iOvergaard added a commit that referenced this pull request Jul 25, 2024
@loivsen @iOvergaard
feat(uui-color-picker): allow the value to be empty (#842)
c3663b0 
* Bugfix: Allow the UUI Color Picker value to be undefined...

* dispatching events

* start with alpha 0

* remove state, update inputvalue when deselecting swatch

* dont dispatch if color did not change

---------

Co-authored-by: Jacob Overgaard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjarnef bjarnef bjarnef left review comments

@iOvergaard iOvergaard iOvergaard approved these changes

Assignees
No one assigned
Labels
feature Something we are looking to build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loivsen @iOvergaard @bjarnef