Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document userinfo endpoint #6849

Merged
merged 4 commits into from
Feb 5, 2025
Merged

Document userinfo endpoint #6849

merged 4 commits into from
Feb 5, 2025

Conversation

bjarnef
Copy link
Contributor

@bjarnef bjarnef commented Feb 4, 2025

Description

What did you add/update/change?
Documentation of new userinfo endpoint from Umbraco 13.6+
umbraco/Umbraco-CMS#17719

Also document of this part would be great, e.g. a custom properties from member like firstName and lastName:

The implementation is build to be extendable, so custom claims can be added to these claims - and the core claims can be removed, too.

Perhaps it should be mentioned sub contains Umbraco member guid key, but not sure if it always guid if integration with external providers.

Type of suggestion

  • Typo/grammar fix
  • Updated outdated content
  • New content
  • Updates related to a new version
  • Other

Product & version (if relevant)

Deadline (if relevant)

When should the content be published?

@bjarnef bjarnef changed the title Update README.md Document userinfo endpoint Feb 4, 2025
@sofietoft sofietoft added category/umbraco-cms review/developer Use this label if an internal developer review is required labels Feb 5, 2025
Copy link
Contributor

@kjac kjac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff @bjarnef ❤️

@sofietoft sofietoft merged commit 09eb05f into umbraco:main Feb 5, 2025
5 checks passed
@bjarnef bjarnef deleted the patch-28 branch February 5, 2025 10:27
@bjarnef
Copy link
Contributor Author

bjarnef commented Feb 5, 2025

Perhaps it should be mentioned sub contains Umbraco member guid key, but not sure if it always guid if integration with external providers.

@kjac it seems sub is member key/guid in this this, but I guess it could be something else with external provider or if overwriting key.

It would also be great somewhere to place to .NET part:

The implementation is build to be extendable, so custom claims can be added to these claims - and the core claims can be removed, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category/umbraco-cms review/developer Use this label if an internal developer review is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants