Skip to content

Update documentation on Templates and Named Sections #6853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 10, 2025

Conversation

sofietoft
Copy link
Contributor

Description

The documentation we had about Templates was slightly outdated, and was structured a little strangely.

I've updated the structure of the article.
Also I've reworked the part about named sections - and removed the separate article we had about the topic, as it was duplicate content.

Type of suggestion

  • Typo/grammar fix
  • Updated outdated content
  • New content
  • Updates related to a new version
  • Other

Copy link
Contributor

@eshanrnh eshanrnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, @sofietoft 🙌I've added some suggestions to v14 article. Can you please add them to v15 as well if it makes sense?

@sofietoft sofietoft requested a review from eshanrnh February 10, 2025 09:19
@@ -150,9 +192,3 @@ The created partial view can now be injected into any template by using the `@Ht
### Tutorials
Copy link
Contributor

@eshanrnh eshanrnh Feb 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Named sections link above takes you to the GitHub page. Might be helpful to update the link.

@@ -150,9 +192,3 @@ The created partial view can now be injected into any template by using the `@Ht
### Tutorials
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Named sections link above takes you to the GitHub page. Might be helpful to update the link.

Copy link
Contributor

@eshanrnh eshanrnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, @sofietoft 💪 I just noticed a broken link while previewing the article and added the suggestion.

@sofietoft
Copy link
Contributor Author

Excellent point @eshanrnh ! 😅
It's referencing the article I deleted - I've removed the link!

@sofietoft sofietoft merged commit 3c83c36 into main Feb 10, 2025
12 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants