Skip to content

CMS: Updates code examples for external login providers for V17#7764

Merged
eshanrnh merged 9 commits into
mainfrom
v17/cms/external-login-code
Jan 16, 2026
Merged

CMS: Updates code examples for external login providers for V17#7764
eshanrnh merged 9 commits into
mainfrom
v17/cms/external-login-code

Conversation

@iOvergaard
Copy link
Copy Markdown
Contributor

@iOvergaard iOvergaard commented Jan 15, 2026

📋 Description

  • Updates the code examples for user authentication and external login providers
  • Adds a Typescript example based on feedback from the CMS team

📎 Related Issues (if applicable)

Fixes #7189

✅ Contributor Checklist

I've followed the Umbraco Documentation Style Guide and can confirm that:

  • Code blocks are correctly formatted.
  • Sentences are short and clear (preferably under 25 words).
  • Passive voice and first-person language (“we”, “I”) are avoided.
  • Relevant pages are linked.
  • All links work and point to the correct resources.
  • Screenshots or diagrams are included if useful.
  • Any code examples or instructions have been tested.
  • Typos, broken links, and broken images are fixed.

Product & Version (if relevant)

V17

Deadline (if relevant)

ASAP

📚 Helpful Resources

Copilot AI review requested due to automatic review settings January 15, 2026 15:32
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates code examples for external login providers in Umbraco V17 documentation. It modernizes C# code samples, adds a new TypeScript example with Lit framework, reorganizes tab examples, and corrects various issues in the authentication configuration code.

Changes:

  • Modernized C# code with nullable annotations, collection expressions, and updated namespace imports
  • Added a comprehensive TypeScript/Lit example for custom login views
  • Reorganized example tabs to prioritize Lit over Vanilla JavaScript
  • Updated TypeScript interface definitions to match actual implementation requirements
Comments suppressed due to low confidence (7)

17/umbraco-cms/reference/security/external-login-providers.md:437

  • Corrected spelling of 'authtication' to 'authentication'.
        // register the generic authtication options (secret, callback, errorhandling, ...)

17/umbraco-cms/reference/security/external-login-providers.md:480

  • Corrected spelling of 'oath' to 'oauth'. OAuth (Open Authorization) is the correct technical term for this authentication protocol.
        // This will redirect error responses from the login provider towards the default umbraco oath login error page

17/umbraco-cms/reference/security/external-login-providers.md:480

  • Corrected spelling of 'oath' to 'oauth'. OAuth (Open Authorization) is the correct technical term for this authentication protocol.
        // This will redirect error responses from the login provider towards the default umbraco oath login error page

17/umbraco-cms/reference/security/external-login-providers.md:461

  • Corrected spelling of 'OathProvider' to 'OAuthProvider'. OAuth (Open Authorization) is the correct technical term.
// the ...AuthenticationOptions method will be part of the OathProvider nuget package you install

17/umbraco-cms/reference/security/external-login-providers.md:421

  • Corrected spelling of 'OathProvider' to 'OAuthProvider'. OAuth (Open Authorization) is the correct technical term.
// this example uses a non existing generic OathProvider NuGet package

17/umbraco-cms/reference/security/external-login-providers.md:445

  • Corrected spelling of 'OathProvider' to 'OAuthProvider'. OAuth (Open Authorization) is the correct technical term.
                    // this Add... method will be part of the OathProvider nuget package you install

17/umbraco-cms/reference/security/external-login-providers.md:461

  • Corrected spelling of 'OathProvider' to 'OAuthProvider'. OAuth (Open Authorization) is the correct technical term.
// the ...AuthenticationOptions method will be part of the OathProvider nuget package you install

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread 17/umbraco-cms/reference/security/external-login-providers.md Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@eshanrnh eshanrnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @iOvergaard 🙌 I’ve added suggestions to remove the use of “we” and to break up a large block of text into smaller paragraphs for improved clarity and readability.

Comment thread 17/umbraco-cms/reference/security/external-login-providers.md Outdated
Comment thread 17/umbraco-cms/reference/security/external-login-providers.md Outdated
Comment thread 17/umbraco-cms/reference/security/external-login-providers.md Outdated
Comment thread 17/umbraco-cms/reference/security/external-login-providers.md Outdated
@eshanrnh eshanrnh merged commit 3b008c4 into main Jan 16, 2026
4 checks passed
@eshanrnh eshanrnh deleted the v17/cms/external-login-code branch February 12, 2026 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Outdated code samples in External Login Provider article (CMS)

3 participants