CMS: Updates code examples for external login providers for V17#7764
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates code examples for external login providers in Umbraco V17 documentation. It modernizes C# code samples, adds a new TypeScript example with Lit framework, reorganizes tab examples, and corrects various issues in the authentication configuration code.
Changes:
- Modernized C# code with nullable annotations, collection expressions, and updated namespace imports
- Added a comprehensive TypeScript/Lit example for custom login views
- Reorganized example tabs to prioritize Lit over Vanilla JavaScript
- Updated TypeScript interface definitions to match actual implementation requirements
Comments suppressed due to low confidence (7)
17/umbraco-cms/reference/security/external-login-providers.md:437
- Corrected spelling of 'authtication' to 'authentication'.
// register the generic authtication options (secret, callback, errorhandling, ...)
17/umbraco-cms/reference/security/external-login-providers.md:480
- Corrected spelling of 'oath' to 'oauth'. OAuth (Open Authorization) is the correct technical term for this authentication protocol.
// This will redirect error responses from the login provider towards the default umbraco oath login error page
17/umbraco-cms/reference/security/external-login-providers.md:480
- Corrected spelling of 'oath' to 'oauth'. OAuth (Open Authorization) is the correct technical term for this authentication protocol.
// This will redirect error responses from the login provider towards the default umbraco oath login error page
17/umbraco-cms/reference/security/external-login-providers.md:461
- Corrected spelling of 'OathProvider' to 'OAuthProvider'. OAuth (Open Authorization) is the correct technical term.
// the ...AuthenticationOptions method will be part of the OathProvider nuget package you install
17/umbraco-cms/reference/security/external-login-providers.md:421
- Corrected spelling of 'OathProvider' to 'OAuthProvider'. OAuth (Open Authorization) is the correct technical term.
// this example uses a non existing generic OathProvider NuGet package
17/umbraco-cms/reference/security/external-login-providers.md:445
- Corrected spelling of 'OathProvider' to 'OAuthProvider'. OAuth (Open Authorization) is the correct technical term.
// this Add... method will be part of the OathProvider nuget package you install
17/umbraco-cms/reference/security/external-login-providers.md:461
- Corrected spelling of 'OathProvider' to 'OAuthProvider'. OAuth (Open Authorization) is the correct technical term.
// the ...AuthenticationOptions method will be part of the OathProvider nuget package you install
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
eshanrnh
left a comment
There was a problem hiding this comment.
Looks great, @iOvergaard 🙌 I’ve added suggestions to remove the use of “we” and to break up a large block of text into smaller paragraphs for improved clarity and readability.
📋 Description
📎 Related Issues (if applicable)
Fixes #7189
✅ Contributor Checklist
I've followed the Umbraco Documentation Style Guide and can confirm that:
Product & Version (if relevant)
V17
Deadline (if relevant)
ASAP
📚 Helpful Resources