Update Forms 16/17/18 docs to match current codebase#8130
Merged
Conversation
Audit of the Forms documentation against the Forms codebase, fixing out-of-date content across versions 16, 17, and 18: Code samples that no longer compile: - WorkflowType.Execute -> ExecuteAsync returning Task<WorkflowExecutionStatus> - FieldPreValueSourceType.GetPreValues -> GetPreValuesAsync(Field?, Form?) - ExportType examples updated for async ExportRecordsAsync and awaited ViewHelper.RenderPartialViewToString - IRecordReaderService returns PagedModel<Record>, not PagedResult<Record> - ValidateField override now includes the IFieldTypeStorage parameter - Removed v8-era namespaces (Umbraco.Core.*) and leftover internal Umbraco.Forms.TestSite namespaces; fixed submissions.schema casing - Old AngularJS setting view aliases replaced with Umb.PropertyEditorUi.* - Replaced AngularJS backoffice view instructions with a pointer to the manifest-based field type article Factual corrections: - Forms 17/18 run on .NET 10 (not .NET 9) - Removed UseSemanticFieldsetRendering (no longer exists) - DisallowedFileUploadExtensions default includes js - Post as XML: "Headers" setting corrected to "Fields", added "Default Element For Fields" (also for Send Form to URL) - SetFormThemeCssFile takes a single path parameter Missing content: - Documented MessageOnSubmitIsHtml setting - Added HeaderHtml/BodyHtml/FooterHtml to Razor email workflow settings - Expanded the list of theme files that can be overridden - Documented the Analytics Processing health check (17/18 only) - Email template and custom markup examples updated to match the shipped templates (RecaptchaEnterprise, autocomplete, ARIA attributes) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Thanks for opening this PR! 🎉 Quick question: Does this PR include any AI-generated content? AI tools are absolutely welcome here! We only ask that you follow our AI contribution guidelines to help keep the documentation consistent and trustworthy. Drop a quick comment to let us know! |
rickbutterfield
added
category/missing-documentation
category/umbraco-forms
category/structure
ai-generated
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Shortened a long sentence in adding-a-type.md across versions 16, 17, and 18. Remaining Vale findings in these files are on pre-existing lines not touched by this PR. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
sofietoft
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Audit of the Forms documentation against the Forms codebase (v17.4.0 working tree, plus the
v16/devbranch for version 16 checks). Fixes out-of-date content across the 16, 17, and 18 Forms docs.Code samples that no longer compile
WorkflowType.Execute→ExecuteAsyncreturningTask<WorkflowExecutionStatus>(adding-a-type, customize-default-workflows)FieldPreValueSourceType.GetPreValues→GetPreValuesAsync(Field?, Form?)(adding-a-prevaluesourcetype)ExportRecordsAsyncand awaitedViewHelper.RenderPartialViewToString; fixedsubmissions.schemacasingIRecordReaderServicereturnsPagedModel<Record>, notPagedResult<Record>(working-with-data)ValidateFieldoverride now includes theIFieldTypeStorageparameterUmbraco.Core.*namespaces and leftover internalUmbraco.Forms.TestSite.*namespacesTextField,Pickers.Content) replaced withUmb.PropertyEditorUi.*equivalentsFactual corrections
UseSemanticFieldsetRenderingfrom configuration docs (setting no longer exists in the codebase)DisallowedFileUploadExtensionsdefault includesjsSetFormThemeCssFiletakes a single path parameterMissing content
MessageOnSubmitIsHtmlsettingHeaderHtml/BodyHtml/FooterHtmlto the Razor email workflow settings in type-detailsautocomplete, ARIA attributes)<summary>tags which are now populatedNotes for reviewers
v16/devbranch of the Forms repository — all affected APIs (async signatures,PagedModel, theme files, workflow settings) are identical to v1718.0.0follows the established convention; there is no v18 Forms branch to verify against yet🤖 Generated with Claude Code