refactor(#960): rename CatalogPrivacy → CatalogRoutingTemplates + relocate address (PR-A)#963
Merged
Merged
Conversation
ccancellieri
force-pushed
the
issue/960-drop-catalog-privacy
branch
from
7be92ee to
33a15dd
Compare
5 tasks
…ocate address PR-A of #960 (rename only; new catalog-private driver + cascade ships separately). Privacy semantics moved to "routing + IAM" after #733 retired the is_private flag. CatalogPrivacy then survived as a vestigial shell wrapping CatalogRoutingDefaults — its class docstring already acknowledged this. Rename the class to its actual purpose and move its _address from ("platform","catalog","privacy") into the existing ("platform","catalog","routing","templates") sub-namespace. - CatalogPrivacy → CatalogRoutingTemplates (class_key auto-flips from "catalog_privacy" to "catalog_routing_templates") - _on_apply_catalog_privacy → _on_apply_catalog_routing_templates - _address: ("platform","catalog","privacy") → ("platform","catalog","routing","templates") - README PUT URL example + 5 docstring cross-refs updated - 7 test files updated in step with the rename Clean break — no compat alias, draft-schema renewal will absorb the stored row-key change.
ccancellieri
force-pushed
the
issue/960-drop-catalog-privacy
branch
from
33a15dd to
d1fc11a
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR-A of #960. New
catalog_elasticsearch_private_driver+ cascade + 3-repo seed sync ship as PR-B.What
Privacy semantics moved to "routing + IAM" after #733 retired the
is_privateflag.CatalogPrivacythen survived as a vestigial shell wrappingCatalogRoutingDefaults— its class docstring already acknowledged this. This PR renames the class to its actual purpose and folds its_addressinto the existingroutingsub-namespace.CatalogPrivacy→CatalogRoutingTemplates(class_keyauto-flips fromcatalog_privacytocatalog_routing_templates)_on_apply_catalog_privacy→_on_apply_catalog_routing_templates_address: ("platform","catalog","privacy")→("platform","catalog","routing","templates")Why split A/B
PR-A is mechanical surface (rename only, zero behaviour change). PR-B introduces a new driver class, IAM DENY URL extension, cascade validator extension, and 3-repo seed JSON sync — large enough to deserve its own review.
Verification
ruffreports 0 new errors on changed files (9 pre-existing F401/F841 on main, identical post-rename)CatalogRoutingTemplates.class_key() == "catalog_routing_templates", address tuple is("platform","catalog","routing","templates"), handler_on_apply_catalog_routing_templatesregisteredNon-goals (PR-B)
catalog_elasticsearch_private_driver_build_private_catalog_routing()helperprivate_deny_{catalog_id}URL pattern to cover/catalogs/{cat}(singular)Relates to #960.