feat: port eslint-plugin-barrel-files

LICENSE

@@ -1,6 +1,7 @@
 The MIT License (MIT)
 
 Copyright (c) 2015 Ben Mosher
+Copyright (c) 2020 modern-webdev
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

README.md

@@ -253,6 +253,10 @@ settings:
 💡 Manually fixable by [editor suggestions](https://eslint.org/docs/latest/use/core-concepts#rule-suggestions).\
 ❌ Deprecated.
 
+| Name                                                                       | Description                    | 💼  | ⚠️  | 🚫  | 🔧  | 💡  | ❌  |
+| :------------------------------------------------------------------------- | :----------------------------- | :-- | :-- | :-- | :-- | :-- | :-- |
+| [avoid-importing-barrel-files](docs/rules/avoid-importing-barrel-files.md) | Forbid importing barrel files. |     |     |     |     |     |     |
+
 ### Helpful warnings
 
 | Name                                                                   | Description                                                                           | 💼          | ⚠️          | 🚫  | 🔧  | 💡  | ❌  |
@@ -277,6 +281,14 @@ settings:
 | [no-nodejs-modules](docs/rules/no-nodejs-modules.md)               | Forbid Node.js builtin modules.                                      |     |     |     |     |     |     |
 | [unambiguous](docs/rules/unambiguous.md)                           | Forbid potentially ambiguous parse goal (`script` vs. `module`).     |     |     |     |     |     |     |
 
+### Performance
+
+| Name                                                           | Description                           | 💼  | ⚠️  | 🚫  | 🔧  | 💡  | ❌  |
+| :------------------------------------------------------------- | :------------------------------------ | :-- | :-- | :-- | :-- | :-- | :-- |
+| [avoid-barrel-files](docs/rules/avoid-barrel-files.md)         | Forbid authoring of barrel files.     |     |     |     |     |     |     |
+| [avoid-namespace-import](docs/rules/avoid-namespace-import.md) | Forbid namespace imports.             |     |     |     |     |     |     |
+| [avoid-re-export-all](docs/rules/avoid-re-export-all.md)       | Forbid re-exporting \* from a module. |     |     |     |     |     |     |
+
 ### Static analysis
 
 | Name                                                                   | Description                                                                          | 💼          | ⚠️  | 🚫    | 🔧  | 💡  | ❌  |

docs/rules/avoid-barrel-files.md

@@ -0,0 +1,29 @@
+# import-x/avoid-barrel-files
+
+<!-- end auto-generated rule header -->
+
+This rule disallows _authoring_ barrel files in your project.
+
+## Rule Details
+
+Examples of **incorrect** code for this rule:
+
+```js
+export { foo } from 'foo'
+export { bar } from 'bar'
+export { baz } from 'baz'
+```
+
+## Options
+
+This rule has the following options, with these defaults:
+
+```js
+"import-x/avoid-barrel-files": ["error", {
+  "amountOfExportsToConsiderModuleAsBarrel": 5
+}]
+```
+
+### `amountOfExportsToConsiderModuleAsBarrel`
+
+This option sets the number of exports that will be considered a barrel file. Anything over will trigger the rule.

docs/rules/avoid-importing-barrel-files.md

@@ -0,0 +1,89 @@
+# import-x/avoid-importing-barrel-files
+
+<!-- end auto-generated rule header -->
+
+This rule aims to avoid importing barrel files that lead to loading large module graphs. This rule is different from the `avoid-barrel-files` rule, which lints against _authoring_ barrel files. This rule lints against _importing_ barrel files.
+
+## Rule Details
+
+Examples of **incorrect** code for this rule:
+
+```js
+// If `foo` is a barrel file leading to a module graph of more than 20 modules
+export { foo } from 'foo'
+```
+
+## Options
+
+This rule has the following options, with these defaults:
+
+```js
+"import-x/avoid-importing-barrel-files": ["error", {
+  allowList: [],
+  maxModuleGraphSizeAllowed: 20,
+  amountOfExportsToConsiderModuleAsBarrel: 3,
+  exportConditions: ["node", "import"],
+  mainFields: ["module", "browser", "main"],
+  extensions: [".js", ".ts", ".tsx", ".jsx", ".json", ".node"],
+}]
+```
+
+### `allowList`
+
+List of modules from which to allow barrel files being imported.
+
+### `maxModuleGraphSizeAllowed`
+
+Maximum allowed module graph size. If an imported module results in loading more than this many modules, it will be considered a barrel file.
+
+### `amountOfExportsToConsiderModuleAsBarrel`
+
+Amount of exports to consider a module as a barrel file.
+
+### `exportConditions`
+
+Export conditions to use when resolving modules.
+
+### `mainFields`
+
+Main fields to use when resolving modules.
+
+### `extensions`
+
+Extensions to use when resolving modules.
+
+### `tsconfig`
+
+TSConfig options to pass to the underlying resolver when resolving modules.
+
+This can be useful when resolving project references in TypeScript.
+
+### `alias`
+
+The rule can accept an `alias` option whose value can be an object that matches Webpack's [resolve.alias](https://webpack.js.org/configuration/resolve/) configuration.
+
+```js
+// eslint.config.js
+import path from 'node:path'
+import { defineConfig } from 'eslint/config'
+import importPlugin from 'eslint-plugin-import-x'
+
+export default defineConfig([
+  {
+    plugins: {
+      'import-x': importPlugin,
+    },
+    rules: {
+      'import-x/avoid-importing-barrel-files': [
+        'error',
+        {
+          alias: {
+            // "@/foo/bar.js" => "./src/foo/bar.js"
+            '@': [path.resolve('.', 'src')],
+          },
+        },
+      ],
+    },
+  },
+])
+```

docs/rules/avoid-namespace-import.md

@@ -0,0 +1,27 @@
+# import-x/avoid-namespace-import
+
+<!-- end auto-generated rule header -->
+
+This rule forbids the use of namespace imports as they can lead to unused imports and prevent treeshaking.
+
+## Rule Details
+
+Examples of **incorrect** code for this rule:
+
+```js
+import * as foo from 'foo'
+```
+
+## Options
+
+This rule has the following options, with these defaults:
+
+```js
+"import-x/avoid-namespace-import": ["error", {
+  allowList: []
+}]
+```
+
+### `allowList`
+
+A list of namespace imports that are allowed.

docs/rules/avoid-re-export-all.md

@@ -0,0 +1,14 @@
+# import-x/avoid-re-export-all
+
+<!-- end auto-generated rule header -->
+
+This rule forbids exporting `*` from a module as it can lead to unused imports and prevent treeshaking.
+
+## Rule Details
+
+Examples of **incorrect** code for this rule:
+
+```js
+export * from 'foo'
+export * as foo from 'foo'
+```

package.json

@@ -78,6 +78,7 @@
     "@typescript-eslint/types": "^8.35.0",
     "comment-parser": "^1.4.1",
     "debug": "^4.4.1",
+    "eslint-barrel-file-utils": "^0.0.15",
     "eslint-import-context": "^0.1.9",
     "is-glob": "^4.0.3",
     "minimatch": "^9.0.3 || ^10.0.1",

src/index.ts

@@ -20,6 +20,10 @@ import warnings from './config/warnings.js'
 import { meta } from './meta.js'
 import { createNodeResolver } from './node-resolver.js'
 import { cjsRequire } from './require.js'
+import avoidBarrelFiles from './rules/avoid-barrel-files.js'
+import avoidImportingBarrelFiles from './rules/avoid-importing-barrel-files.js'
+import avoidNamespaceImport from './rules/avoid-namespace-import.js'
+import avoidReExportAll from './rules/avoid-re-export-all.js'
 import consistentTypeSpecifierStyle from './rules/consistent-type-specifier-style.js'
 import default_ from './rules/default.js'
 import dynamicImportChunkname from './rules/dynamic-import-chunkname.js'
@@ -131,6 +135,12 @@ const rules = {
 
   // deprecated aliases to rules
   'imports-first': importsFirst,
+
+  // barrel files
+  'avoid-barrel-files': avoidBarrelFiles,
+  'avoid-importing-barrel-files': avoidImportingBarrelFiles,
+  'avoid-namespace-import': avoidNamespaceImport,
+  'avoid-re-export-all': avoidReExportAll,
 } satisfies Record<string, TSESLint.RuleModule<string, readonly unknown[]>>
 
 // Base Plugin Object

src/rules/avoid-barrel-files.ts

@@ -0,0 +1,100 @@
+import { createRule } from '../utils/index.js'
+
+export interface Options {
+  amountOfExportsToConsiderModuleAsBarrel: number
+}
+
+export type MessageId = 'avoidBarrel'
+
+const defaultOptions: Options = {
+  amountOfExportsToConsiderModuleAsBarrel: 3,
+}
+
+export default createRule<[Options?], MessageId>({
+  name: 'avoid-barrel-files',
+  meta: {
+    type: 'suggestion',
+    docs: {
+      description: 'Forbid authoring of barrel files.',
+      category: 'Performance',
+      recommended: true,
+    },
+    schema: [
+      {
+        type: 'object',
+        properties: {
+          amountOfExportsToConsiderModuleAsBarrel: {
+            type: 'number',
+            description:
+              'Minimum amount of exports to consider module as barrelfile',
+            default: 3,
+          },
+        },
+        additionalProperties: false,
+      },
+    ],
+    messages: {
+      avoidBarrel:
+        'Avoid barrel files, they slow down performance, and cause large module graphs with modules that go unused.',
+    },
+  },
+  defaultOptions: [defaultOptions],
+  create(context) {
+    const options = context.options[0] || defaultOptions
+    const amountOfExportsToConsiderModuleAsBarrel =
+      options.amountOfExportsToConsiderModuleAsBarrel
+
+    return {
+      Program(node) {
+        let declarations = 0
+        let exports = 0
+
+        for (const n of node.body) {
+          if (n.type === 'VariableDeclaration') {
+            declarations += n.declarations.length
+          }
+
+          if (
+            n.type === 'FunctionDeclaration' ||
+            n.type === 'ClassDeclaration' ||
+            n.type === 'TSTypeAliasDeclaration' ||
+            n.type === 'TSInterfaceDeclaration'
+          ) {
+            declarations += 1
+          }
+
+          if (n.type === 'ExportNamedDeclaration') {
+            exports += n.specifiers.length
+          }
+
+          if (n.type === 'ExportAllDeclaration' && n?.exportKind !== 'type') {
+            exports += 1
+          }
+
+          if (n.type === 'ExportDefaultDeclaration') {
+            if (
+              n.declaration.type === 'FunctionDeclaration' ||
+              n.declaration.type === 'CallExpression'
+            ) {
+              declarations += 1
+            } else if (n.declaration.type === 'ObjectExpression') {
+              exports += n.declaration.properties.length
+            } else {
+              exports += 1
+            }
+          }
+        }
+
+        if (
+          exports > declarations &&
+          exports > amountOfExportsToConsiderModuleAsBarrel
+        ) {
+          context.report({
+            node,
+            messageId: 'avoidBarrel',
+          })
+        }
+      },
+    }
+  },
+})