Skip to content

fix: app name resolution for Firefox-based browsers#951

Open
zen1337th wants to merge 1 commit into
unchihugo:masterfrom
zen1337th:fix/mediaplayer
Open

fix: app name resolution for Firefox-based browsers#951
zen1337th wants to merge 1 commit into
unchihugo:masterfrom
zen1337th:fix/mediaplayer

Conversation

@zen1337th

Copy link
Copy Markdown
Contributor

Summary

fixes app name resolution for Firefox based browsers

Motivation

I looked through the FluentFlyout repo's issues and found this bug report right away. Since I use Firefox myself (and somehow never noticed the install-hash displaying in the MediaFlyout instead of the app name) I decided to fix this myself.

Closes #949

Type of Change

  • Feature
  • Bug fix
  • Refactor (no functional changes)
  • Style (formatting, naming)
  • Other

What Changed

Fall back to resolving the AppUserModelId through the shell Apps folder when no process path matches, so browsers reporting an install-hash id (like any Firefox based browser) show their correct app name and icon instead of their raw id

image

Checklist

  • Code changes are manually tested and working.
  • Formatting and naming are consistent with the project.
  • Self-review of changes is done.
  • AI tools were used (if yes, I reviewed and fully understand the changes myself).

@unchihugo unchihugo left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @zen1337th, this is a great upgrade to our existing system, and I'm glad you were able to figure this out!

I'm just wondering, have you measured the performance differences between our current system (looking through processes) with this new fallback method for both hits and misses? If it's meaningfully better (which I believe it might be) we could look into switching this new fallback method with the process lookup method as a separate PR in the future.

@zen1337th

Copy link
Copy Markdown
Contributor Author

hi @zen1337th, this is a great upgrade to our existing system, and I'm glad you were able to figure this out!

I'm just wondering, have you measured the performance differences between our current system (looking through processes) with this new fallback method for both hits and misses? If it's meaningfully better (which I believe it might be) we could look into switching this new fallback method with the process lookup method as a separate PR in the future.

Hi @unchihugo, I haven't seen any performance indifferences compared to the latest official release on my personal computer, but I can do more testing on different devices later once I'm home.

I'll give you a reply here with my observations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Firefox and Zen Browser show a raw app ID instead of the app name/icon in Media Flyout

2 participants