fix: app name resolution for Firefox-based browsers#951
Conversation
There was a problem hiding this comment.
hi @zen1337th, this is a great upgrade to our existing system, and I'm glad you were able to figure this out!
I'm just wondering, have you measured the performance differences between our current system (looking through processes) with this new fallback method for both hits and misses? If it's meaningfully better (which I believe it might be) we could look into switching this new fallback method with the process lookup method as a separate PR in the future.
Hi @unchihugo, I haven't seen any performance indifferences compared to the latest official release on my personal computer, but I can do more testing on different devices later once I'm home. I'll give you a reply here with my observations. |
Summary
fixes app name resolution for Firefox based browsers
Motivation
I looked through the FluentFlyout repo's issues and found this bug report right away. Since I use Firefox myself (and somehow never noticed the install-hash displaying in the MediaFlyout instead of the app name) I decided to fix this myself.
Closes #949
Type of Change
What Changed
Fall back to resolving the AppUserModelId through the shell Apps folder when no process path matches, so browsers reporting an install-hash id (like any Firefox based browser) show their correct app name and icon instead of their raw id
Checklist