fix: extra errors on stan and psalm, fix tests

src/Definition/Encoding/PhpArrayToRelationshipCollectionEncoderInterface.php

@@ -7,12 +7,15 @@
 use Undabot\JsonApi\Definition\Model\Resource\Relationship\RelationshipCollectionInterface;
 use Undabot\JsonApi\Implementation\Encoding\Exception\JsonApiEncodingException;
 
+/** @psalm-suppress PossiblyUnusedMethod */
 interface PhpArrayToRelationshipCollectionEncoderInterface
 {
     /**
      * @param array<string,array<string,mixed>> $relationships
      *
      * @throws JsonApiEncodingException
+     *
+     * @psalm-suppress PossiblyUnusedMethod
      */
     public function encode(array $relationships): RelationshipCollectionInterface;
 }

src/Definition/Exception/Request/UnsupportedFilterAttributeGivenException.php

@@ -4,6 +4,7 @@
 
 namespace Undabot\JsonApi\Definition\Exception\Request;
 
+/** @psalm-suppress UnusedClass */
 class UnsupportedFilterAttributeGivenException extends RequestException
 {
     /**

src/Definition/Exception/Request/UnsupportedIncludeValuesGivenException.php

@@ -4,6 +4,7 @@
 
 namespace Undabot\JsonApi\Definition\Exception\Request;
 
+/** @psalm-suppress UnusedClass */
 class UnsupportedIncludeValuesGivenException extends RequestException
 {
     /**

src/Definition/Exception/Request/UnsupportedPaginationRequestedException.php

@@ -4,4 +4,5 @@
 
 namespace Undabot\JsonApi\Definition\Exception\Request;
 
+/** @psalm-suppress UnusedClass */
 class UnsupportedPaginationRequestedException extends RequestException {}

src/Definition/Exception/Request/UnsupportedSparseFieldsetRequestedException.php

@@ -4,6 +4,7 @@
 
 namespace Undabot\JsonApi\Definition\Exception\Request;
 
+/** @psalm-suppress UnusedClass */
 class UnsupportedSparseFieldsetRequestedException extends RequestException
 {
     /**

src/Implementation/Factory/PaginationFactory.php

@@ -36,7 +36,7 @@ public function fromArray(array $paginationParams): PaginationInterface
     }
 
     /**
-     * @param array<string, int> $paginationParams
+     * @param array<string, int|string> $paginationParams
      *
      * @throws AssertionFailedException
      */
@@ -67,13 +67,13 @@ private function makePageBasedPagination(array $paginationParams): PageBasedPagi
         }
 
         return new PageBasedPagination(
-            $paginationParams[PageBasedPagination::PARAM_PAGE_NUMBER],
-            $paginationParams[PageBasedPagination::PARAM_PAGE_SIZE]
+            (int) $paginationParams[PageBasedPagination::PARAM_PAGE_NUMBER],
+            (int) $paginationParams[PageBasedPagination::PARAM_PAGE_SIZE]
         );
     }
 
     /**
-     * @param array<string, int> $paginationParams
+     * @param array<string, int|string> $paginationParams
      *
      * @throws AssertionFailedException
      */
@@ -109,8 +109,8 @@ private function makeOffsetBasedPagination(array $paginationParams): OffsetBased
         );
 
         return new OffsetBasedPagination(
-            $paginationParams[OffsetBasedPagination::PARAM_PAGE_OFFSET],
-            $paginationParams[OffsetBasedPagination::PARAM_PAGE_LIMIT]
+            (int) $paginationParams[OffsetBasedPagination::PARAM_PAGE_OFFSET],
+            (int) $paginationParams[OffsetBasedPagination::PARAM_PAGE_LIMIT]
         );
     }
 }

src/Implementation/Model/Document/DocumentData.php

@@ -9,15 +9,13 @@
 use Undabot\JsonApi\Definition\Model\Resource\ResourceIdentifierCollectionInterface;
 use Undabot\JsonApi\Definition\Model\Resource\ResourceIdentifierInterface;
 use Undabot\JsonApi\Definition\Model\Resource\ResourceInterface;
-use Undabot\JsonApi\Implementation\Model\Resource\ResourceCollection;
-use Undabot\JsonApi\Implementation\Model\Resource\ResourceIdentifierCollection;
 
 /** @psalm-suppress UnusedClass */
 class DocumentData implements DocumentDataInterface
 {
-    private null|ResourceCollection|ResourceIdentifierCollection|ResourceIdentifierInterface|ResourceInterface $data;
+    private mixed $data;
 
-    public function __construct(null|ResourceCollection|ResourceIdentifierCollection|ResourceIdentifierInterface|ResourceInterface $data)
+    public function __construct(mixed $data)
     {
         $this->makeSureDataIsValid($data);
         $this->data = $data;

src/Implementation/Model/Resource/Attribute/Attribute.php

@@ -16,6 +16,8 @@ class Attribute implements AttributeInterface
 
     /**
      * @param mixed $value
+     *
+     * @psalm-suppress PossiblyUnusedMethod
      */
     public function __construct(string $name, $value)
     {

src/Implementation/Model/Resource/Attribute/AttributeCollection.php

@@ -7,6 +7,7 @@
 use Undabot\JsonApi\Definition\Model\Resource\Attribute\AttributeCollectionInterface;
 use Undabot\JsonApi\Definition\Model\Resource\Attribute\AttributeInterface;
 
+/** @psalm-suppress UnusedClass */
 class AttributeCollection implements AttributeCollectionInterface
 {
     /** @var AttributeInterface[] */

src/Implementation/Model/Resource/Resource.php

@@ -10,6 +10,7 @@
 use Undabot\JsonApi\Definition\Model\Resource\Relationship\RelationshipCollectionInterface;
 use Undabot\JsonApi\Definition\Model\Resource\ResourceInterface;
 
+/** @psalm-suppress UnusedClass */
 class Resource implements ResourceInterface
 {
     /** @var string */

src/Implementation/Model/Resource/ResourceCollection.php

@@ -6,17 +6,20 @@
 
 use Assert\Assertion;
 use Assert\AssertionFailedException;
-use InvalidArgumentException;
 use Undabot\JsonApi\Definition\Model\Resource\ResourceCollectionInterface;
 use Undabot\JsonApi\Definition\Model\Resource\ResourceInterface;
 
+/** @psalm-suppress UnusedClass */
 final class ResourceCollection implements ResourceCollectionInterface
 {
-    /** @var ResourceInterface[] */
-    private $resources;
+    /**
+     * @var array<ResourceInterface>
+     */
+    private array $resources;
 
     /** @param ResourceInterface[] $resources */
     /** @psalm-suppress PossiblyUnusedMethod */
+    /** @phpstan-ignore-next-line */
     public function __construct(array $resources)
     {
         try {

src/Util/Exception/ValidationException.php

@@ -12,15 +12,18 @@ class ValidationException extends \Exception
     /** @psalm-suppress UnusedProperty */
     private mixed $value;
 
-    /** @var array<int,mixed> */
-    /** @psalm-suppress UnusedProperty */
+    /**
+     * @var array<int, mixed>
+     *
+     * @psalm-suppress UnusedProperty
+     */
+    /** @phpstan-ignore-next-line */
     private array $constraints;
 
     /**
-     * ValidationException constructor.
-     *
      * @param array<int,mixed> $constraints
      *
+     * @psalm-suppress UnusedProperty
      * @psalm-suppress PossiblyUnusedMethod
      */
     public function __construct(

src/Util/ValidResourceAssertion.php

@@ -8,6 +8,8 @@
 
 /**
  * @internal
+ *
+ * @psalm-suppress UnusedClass
  */
 final class ValidResourceAssertion
 {

tests/Unit/Encoding/PhpArray/Encode/ErrorToPhpArrayEncoderTest.php

@@ -52,11 +52,11 @@ public function testItCanBeConstructed(): void
     public function testEncoderSuccessfullyEncodesPrimitiveValues(): void
     {
         $error = $this->createMock(ErrorInterface::class);
-        $error->expects(self::exactly(2))->method('getId')->willReturn('id');
-        $error->expects(self::exactly(2))->method('getStatus')->willReturn('status 1');
-        $error->expects(self::exactly(2))->method('getCode')->willReturn('code 1');
-        $error->expects(self::exactly(2))->method('getTitle')->willReturn('title 1');
-        $error->expects(self::exactly(2))->method('getDetail')->willReturn('detail 1');
+        $error->expects(self::exactly(1))->method('getId')->willReturn('id');
+        $error->expects(self::exactly(1))->method('getStatus')->willReturn('status 1');
+        $error->expects(self::exactly(1))->method('getCode')->willReturn('code 1');
+        $error->expects(self::exactly(1))->method('getTitle')->willReturn('title 1');
+        $error->expects(self::exactly(1))->method('getDetail')->willReturn('detail 1');
 
         $encoded = $this->errorEncoder->encode($error);
         self::assertIsArray($encoded);
@@ -73,13 +73,13 @@ public function testErrorEncoderWillCallSpecificObjectEncoders(): void
         $error = $this->createMock(ErrorInterface::class);
 
         $link = $this->createMock(LinkInterface::class);
-        $error->expects(self::exactly(2))->method('getAboutLink')->willReturn($link);
+        $error->expects(self::exactly(1))->method('getAboutLink')->willReturn($link);
 
         $source = $this->createMock(SourceInterface::class);
-        $error->expects(self::exactly(2))->method('getSource')->willReturn($source);
+        $error->expects(self::exactly(1))->method('getSource')->willReturn($source);
 
         $meta = $this->createMock(MetaInterface::class);
-        $error->expects(self::exactly(2))->method('getMeta')->willReturn($meta);
+        $error->expects(self::exactly(1))->method('getMeta')->willReturn($meta);
 
         $encoded = $this->errorEncoder->encode($error);
         self::assertIsArray($encoded);