CLDR-19466 Document decimal format test data files and usage in README by younies · Pull Request #5813 · unicode-org/cldr

younies · 2026-06-10T13:18:54Z

CLDR-19466

This PR completes the ticket.

Summary

Addressed PR #5709 feedback by adding a comprehensive README.md to common/testData/decimal/.

Key Details

File Scopes: Documented what is in each test file, explicitly clarifying that decimals_modern_locales.tsv covers modern locales minus the core locales in decimals.tsv.
TSV Schema: Defined all columns (locale, number_format, format_length, input, expected).
Testing & Maintenance: Added instructions for automated test execution (TestDecimalFormat), manual spreadsheet inspection, and data regeneration (GenerateDecimalFormatTestData).

ALLOW_MANY_COMMITS=true

jira-pull-request-webhook · 2026-06-10T13:26:27Z

Notice: the branch changed across the force-push!

common/testData/decimal/README.md is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

macchiati · 2026-06-10T14:25:17Z

@@ -0,0 +1,62 @@
+# CLDR Decimal Format Test Data (`common/testData/decimal`)
+
+This directory contains Tab-Separated Values (TSV) files used as a solid blueprint for testing and verifying decimal and compact decimal formats in CLDR, based on ICU4J.


Suggested change

This directory contains Tab-Separated Values (TSV) files used as a solid blueprint for testing and verifying decimal and compact decimal formats in CLDR, based on ICU4J.

This directory contains Tab-Separated Values (TSV) files used for testing decimal and compact decimal formats in CLDR.

This is more accurate and avoids the awkward phrasing "solid blueprint"

macchiati · 2026-06-10T14:28:45Z

+The test data is organized into three separate files to separate core verification from extended coverage:
+
+1. **`decimals.tsv`**
+   Contains verification tests for the **core** CLDR locales across standard number formats, compact format lengths, and representative numeric input values.


Suggested change

Contains verification tests for the **core** CLDR locales across standard number formats, compact format lengths, and representative numeric input values.

Contains verification tests for a selected set of numbers and locales that illustrate most features of number formatting, covering standard number formats, compact format lengths, and representative numeric input values.

macchiati · 2026-06-10T14:30:34Z

+   Contains verification tests for the **core** CLDR locales across standard number formats, compact format lengths, and representative numeric input values.
+
+2. **`decimals_modern_locales.tsv`**
+   Contains verification tests for all **modern** CLDR locales **minus** the core locales covered in `decimals.tsv`.


Suggested change

Contains verification tests for all **modern** CLDR locales **minus** the core locales covered in `decimals.tsv`.

Contains verification tests for all **modern-coverage** CLDR locales **minus** the locales covered in `decimals.tsv`. It also only uses a small set of selected numbers.

macchiati · 2026-06-10T14:31:56Z

+   Contains verification tests for all **modern** CLDR locales **minus** the core locales covered in `decimals.tsv`.
+
+3. **`decimals_extended_numbers.tsv`**
+   Contains extended numeric test inputs (covering edge cases, large numbers, and small fractions) across standard formats and core locales for comprehensive verification.


Suggested change

Contains extended numeric test inputs (covering edge cases, large numbers, and small fractions) across standard formats and core locales for comprehensive verification.

Contains extended numeric test inputs (covering edge cases, large numbers, and small fractions) across standard formats and selected locales for more comprehensive verification.

macchiati · 2026-06-10T14:33:27Z

+* **`number_format`**: The number format dimension (`decimal`, `percent`, `scientific`).
+* **`format_length`**: The compact format length (`short`, `long`). If empty/blank, it represents standard non-compact formatting.
+* **`input`**: The floating-point numeric input value (e.g., `1.2`, `1234565.0`).
+* **`expected`**: The literal expected output string, including all correct localized digits, grouping separators, percent signs, and bi-directional control characters (such as `\u200E` / LRM).


Suggested change

* **`expected`**: The literal expected output string, including all correct localized digits, grouping separators, percent signs, and bi-directional control characters (such as `\u200E` / LRM).

* **`expected`**: The expected output string, including all correct localized digits, grouping separators, percent signs, and bi-directional control characters (such as `\u200E` / LRM).

macchiati · 2026-06-10T14:35:15Z

+
+### 1. Automated Testing
+
+#### Testing in Java


Drop this whole section

macchiati · 2026-06-10T14:35:33Z

+mvn test -pl tools/cldr-code -Dtest=TestDecimalFormat
+```
+
+#### Testing in Other Languages


Drop this whole section also

macchiati · 2026-06-10T14:36:14Z

+3. Invokes your target number formatting implementation using the parsed parameters and numeric input.
+4. Asserts that the generated output exactly matches the `expected` UTF-8 literal string.
+
+### 2. Manual Verification


Dropped the numbering on these sections

sffc

+1 on all of @macchiati's comments

younies · 2026-06-10T17:58:40Z

thanks @macchiati for the comments, I will follow the same style with the currency testing too.

See unicode-org#5813

jira-pull-request-webhook · 2026-06-10T17:59:21Z

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

sffc

The prose is fine, though in currency data, where we have more dimensions, I think we should be more clear and specific about which sets of options are used where.

github-actions Bot assigned younies Jun 10, 2026

younies force-pushed the decimal-testdata-readme branch from 9bf7848 to d45ee3e Compare June 10, 2026 13:26

younies requested review from macchiati and sffc June 10, 2026 13:27

macchiati requested changes Jun 10, 2026

View reviewed changes

sffc reviewed Jun 10, 2026

View reviewed changes

younies requested review from macchiati and sffc June 10, 2026 17:58

CLDR-19466 Document decimal format test data files and usage in README

e6663a7

See unicode-org#5813

younies force-pushed the decimal-testdata-readme branch from 9cf8126 to e6663a7 Compare June 10, 2026 17:59

sffc approved these changes Jun 10, 2026

View reviewed changes

		@@ -0,0 +1,62 @@
		# CLDR Decimal Format Test Data (`common/testData/decimal`)

		This directory contains Tab-Separated Values (TSV) files used as a solid blueprint for testing and verifying decimal and compact decimal formats in CLDR, based on ICU4J.

	Contains verification tests for the core CLDR locales across standard number formats, compact format lengths, and representative numeric input values.
	Contains verification tests for a selected set of numbers and locales that illustrate most features of number formatting, covering standard number formats, compact format lengths, and representative numeric input values.

	Contains verification tests for all modern CLDR locales minus the core locales covered in `decimals.tsv`.
	Contains verification tests for all modern-coverage CLDR locales minus the locales covered in `decimals.tsv`. It also only uses a small set of selected numbers.

	Contains extended numeric test inputs (covering edge cases, large numbers, and small fractions) across standard formats and core locales for comprehensive verification.
	Contains extended numeric test inputs (covering edge cases, large numbers, and small fractions) across standard formats and selected locales for more comprehensive verification.

	* `expected`: The literal expected output string, including all correct localized digits, grouping separators, percent signs, and bi-directional control characters (such as `\u200E` / LRM).
	* `expected`: The expected output string, including all correct localized digits, grouping separators, percent signs, and bi-directional control characters (such as `\u200E` / LRM).

Uh oh!

Conversation

younies commented Jun 10, 2026

Summary

Key Details

Uh oh!

jira-pull-request-webhook Bot commented Jun 10, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sffc left a comment

Choose a reason for hiding this comment

Uh oh!

younies commented Jun 10, 2026

Uh oh!

jira-pull-request-webhook Bot commented Jun 10, 2026

Uh oh!

sffc left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants