Skip to content

Comments

Add FFI type LocaleStatics and include casemap-relevant locales on it#7642

Open
Manishearth wants to merge 2 commits intounicode-org:mainfrom
Manishearth:locale-statics
Open

Add FFI type LocaleStatics and include casemap-relevant locales on it#7642
Manishearth wants to merge 2 commits intounicode-org:mainfrom
Manishearth:locale-statics

Conversation

@Manishearth
Copy link
Member

Fixes #7603

@Manishearth Manishearth requested a review from sffc February 12, 2026 00:51
Copy link
Member

@robertbastian robertbastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like the design of having a type that is only used to spawn references to another type.

These &'statics solve a problem for casemap, they should live on the casemapper. If another type also needs locale_nl() in the future, we can also add it on that type – a method that returns a pointer is very cheap.

@Manishearth
Copy link
Member Author

Manishearth commented Feb 12, 2026

These &'statics solve a problem for casemap, they should live on the casemapper. If another type also needs locale_nl() in the future, we can also add it on that type – a method that returns a pointer is very cheap.

This is a design I am open to, @sffc dispreferred it. Please see the discussion on #7642 (though that specific design may have been dispreferred when we discussed this in person)

The idea is that this type can add more locales over time if needed.

@robertbastian
Copy link
Member

This is me joining the discussion

@Manishearth
Copy link
Member Author

Yes, please continue the discussion there, because some of this has already been discussed a bit and I would not like to have to rehash things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose casemap-relevant static locales over FFI

3 participants