Benchmark for BoundLocaleDataProvider#7663
Draft
sffc wants to merge 21 commits intounicode-org:mainfrom
Draft
Conversation
Member
Author
|
I added a bench on the old ZeroMap struct: |
Member
|
Can you add a benchmark for loading like 10 names? I don't think loading 300+ names at once is the most realistic use case. |
Member
Author
It is a realistic use case, because pickers have a lot of regions/languages, but I added one to load 10% of the names. |
Member
Author
|
I want to point out that the benchmark performance is more dependent on the shape of the data build than the exact workload. I built a postcard file containing display names data for all regions and all locales. If I were to use a postcard file containing display names for only one locale, then the diff is going to be smaller. |
sffc
added a commit
that referenced
this pull request
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #3260
Merge of #7662 and #7621 with a benchmark.
I built regionnames.postcard like this:
cargo run -p icu4x-datagen --all-features -- -m LocaleNamesRegionLongV1 CaseMapV1 PluralsCardinalV1 TimezoneNamesLocationsOverrideV1 --format blob -o _debug/regionnames.postcardI included the target marker as well as a small handful of others to simulate walking through the marker trie.