Replace ByteStr with SliceWithIndices and SerdeByteStr#7748
Open
Manishearth wants to merge 5 commits intounicode-org:mainfrom
Open
Replace ByteStr with SliceWithIndices and SerdeByteStr#7748Manishearth wants to merge 5 commits intounicode-org:mainfrom
Manishearth wants to merge 5 commits intounicode-org:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7725
This was primarily agent-driven.
ByteStr is used in
constcode to abstract over&[(T, usize)]whereTcan be&stror&[u8].SliceWithIndicesis the same concept represented as an enum. This is builder code, so it doesn't matter that much.ByteStr was also used in serde code to allow serializing/deserializing from a byte sequence or a string. I'm not 100% clear if that is actually still necessary: can we just ser/de the store. I didn't want to break anything, so I kept the existing behavior. I'm hoping @sffc can have a look and perform further cleanups if necessary.
I did need to add anFigured out a cleaner way to do it.eitherdependency to write a convenient iterator type. It's internal, so I can also choose to not do that and iterate manually instead.