Draft
Conversation
Manishearth
reviewed
Mar 18, 2026
Member
Manishearth
left a comment
Manishearth
left a comment
There was a problem hiding this comment.
In favor of the general implementation. I think the way you handle method docs/pub/etc is clever.
This is exactly along the lines as what I was envisioning for transparent casts for a long time, and is significantly better than my imagined level of complexity.
Member
Author
|
Thanks; if this direction looks good to you then I'll clean up this PR and get it ready for merging. |
Manishearth
reviewed
Mar 19, 2026
| /// Implements [`ZeroFrom`](crate::ZeroFrom) on a transparent type | ||
| /// from a reference to the inner type. | ||
| /// | ||
| /// Also supports creating concrete functions. |
Member
There was a problem hiding this comment.
nit:
Suggested change
| /// Also supports creating concrete functions. | |
| /// Also supports adding concrete conversion functions between various reference types. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Latest attempt at #7607
Looking for feedback on the general approach, and then on the concrete implementation.
Changelog
zerofrom: Adds macro to derive ZeroFrom and concrete functions for repr(transparent) conversions
zerofrom::transparent!