Add APIs and tests for currency sign options to CurrencyFormatter#7790
Open
younies wants to merge 1 commit intounicode-org:mainfrom
Open
Add APIs and tests for currency sign options to CurrencyFormatter#7790younies wants to merge 1 commit intounicode-org:mainfrom
younies wants to merge 1 commit intounicode-org:mainfrom
Conversation
- Introduced `CurrencySign` enum to control formatting of negative currency values, supporting both standard and accounting styles. - Updated `CurrencyFormatterOptions` to include a `currency_sign` field, defaulting to `Standard`. - Added tests for accounting style formatting in `test_en_us_accounting`.
sffc
approved these changes
Mar 19, 2026
|
|
||
| /// The sign style for negative currency values. | ||
| /// Default is [`CurrencySign::Standard`]. | ||
| pub currency_sign: CurrencySign, |
Member
There was a problem hiding this comment.
Nit: All options should be optional
Suggested change
| pub currency_sign: CurrencySign, | |
| pub currency_sign: Option<CurrencySign>, |
Probably width should be optional, too.
Member
|
Note: the changelog needs to follow a specific format. You had put:
I changed it, according to https://github.com/unicode-org/icu4x/blob/main/documents/process/changelog.md Also, now that we have the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CurrencySignenum to control formatting of negative currency values, supporting both standard and accounting styles.CurrencyFormatterOptionsto include acurrency_signfield, defaulting toStandard.test_en_us_accountingto implement the new behaviour in the next PRChangelog
icu_experimental/currency: Add options for accounting currency sign
CurrencySignCurrencyFormatterOptions::currency_signimpl From<CurrencySign> for CurrencyFormatterOptions