Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix term link errors #1023

Merged
merged 6 commits into from
Feb 20, 2025
Merged

Fix term link errors #1023

merged 6 commits into from
Feb 20, 2025

Conversation

aphillips
Copy link
Member

@aphillips aphillips commented Feb 18, 2025 •
edited
Loading

Fix errors in term highlighting. The missing terms are:

  • annotation (not fixed, no longer used formally in the spec)
  • bad-option-error (fixed here)
  • error (not fixed)
  • expression-resolution (fixed here)
  • field-option (fixed here)
  • formatter (not fixed)
  • function-resolution (fixed here)
  • literal-resolution (fixed here)
  • namespace (fixed here)
  • option-value (not fixed)
  • style-option (fixed here)
  • variable-resolution (fixed here)
  • whitespace (not fixed)

@aphillips
Fix term link errors
d83b7b5 
Fix errors in term highlighting
@aphillips
Update formatting.md
109e24c 
Provide link targets for super-common terms _literal resolution_, _variable resolution_ and _function resolution_
eemeli
eemeli reviewed Feb 18, 2025
View reviewed changes
@aphillips aphillips added fast-track Non-spec editorial changes, etc. specification out-of-scope? LDML47 LDML 47 Release (Stable) labels Feb 19, 2025
@aphillips aphillips marked this pull request as ready for review February 19, 2025 00:07
@aphillips aphillips requested a review from macchiati February 19, 2025 00:07
@aphillips aphillips requested a review from eemeli February 19, 2025 14:37
eemeli
eemeli approved these changes Feb 19, 2025
View reviewed changes
Copy link
Collaborator

@eemeli eemeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, provided that the suggestion restoring "and Markup" is accepted.

@aphillips @eemeli
Update spec/formatting.md
358e9d8 
Co-authored-by: Eemeli Aro <[email protected]>
@aphillips aphillips merged commit 9c9ecfc into main Feb 20, 2025
1 check passed
@aphillips aphillips deleted the aphillips-linkify-errors branch February 20, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eemeli eemeli eemeli approved these changes

@macchiati macchiati Awaiting requested review from macchiati

Assignees
No one assigned
Labels
fast-track Non-spec editorial changes, etc. LDML47 LDML 47 Release (Stable) out-of-scope? specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aphillips @eemeli