Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@unifiprotocol/core-sdk v6.8.4 | @unifiprotocol/shell v0.5.15 #59

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

austin-fleming
Copy link
Contributor

example

Description


Asana Ticket

  • core-sdk: update ui label of metamaskCompatible connector to Web3 Compatible
  • Update shell + core-sdk versions

Known Impacted Areas of Code


Steps taken to Recreate / Verify


  • Open connect modal for chain with Web3 Compatible as wallet option

Checklists


Pull Request Author

I have verified...

  • Progressive code cleanup
  • Satisfies requirements
  • Test coverage

Team Code Reviewer: (enter name here)

I have verified...

  • Satisfies requirements
  • Runs error-free
  • Test coverage

Copy link
Contributor

@clostao clostao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good but version pumping is done over master branch without included it in a PR. You can go on though

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 4, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3963120
Status: ✅  Deploy successful!
Preview URL: https://ea6e586c.unifi-ui-sdk.pages.dev
Branch Preview URL: https://fix-web-compatible-typo.unifi-ui-sdk.pages.dev

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants