Declare support for Python3.12#1897
Declare support for Python3.12#1897cosmicBboy merged 10 commits intounionai-oss:mainfrom g-as:feature/python3.12
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1897 +/- ##
==========================================
- Coverage 94.28% 93.37% -0.91%
==========================================
Files 91 121 +30
Lines 7013 9365 +2352
==========================================
+ Hits 6612 8745 +2133
- Misses 401 620 +219 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
thanks @g-as ! been wanting to do this for a while, thanks for taking the initiative on this.
We can add exceptions in the CI workflow to only run pyspark on 3.12 for pyspark 4.0 |
|
Hi @cosmicBboy! Excluded I ignored the rest of the pylint warnings so linters should pass (and thus tests should run). I'll let you decide on how you want to address those. |
|
Hi @cosmicBboy, as you've seen, the linting workflow fails for I think it is related to this. I thus added |
|
Hi @cosmicBboy I also added
Hopefully everything will run now. |
Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com>
Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com>
Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com>
Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com>
Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com>
…d addressing Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com>
…ce it's no longer installed by default with python 3.12 Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com>
it is required in noxfile and not automatically provided by python >= 3.12 Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com>
typing_extensions is currently required by all python versions Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com>
Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com>
|
Yay \o/ What do you want to do about the coverage? |
|
The coverage on this project has consistently been finicky, will address that in a seperate PR. In the mean time let's go ahead and merge this. |
|
Thanks for the contribution @g-as ! and congrats on your first PR to pandera 🚀 |
|
Thanks! Are you interested in me adding 3.13 support? Removing 3.8? |
|
@g-as thanks for the effort! Re: 3.8, let's go ahead and sunset 3.8 (since it's eol'd for a few months now) Re: 3.13+ support, 3.13 and 3.14 has introduced breaking changes to runtime type checkers. For context, see:
Besides being an entertaining read, it does provide a path forward for what library maintainers will have to do to address the breaking changes. Would you mind opening tickets for supporting 3.13 and 3.14? |
* declared support for python 3.12 Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> * set python3.8 as min python in setup's 'python_requires' Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> * bumped pylint to <3.3 (3.2.x latest to be run with 3.8) Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> * added pyupgrade and applied modifications Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> * .github/tests: skipped pyspark tests on 3.12 Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> * TEMP: disabled pylint warnings (possibly-used-before-assignment). need addressing Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> * .github: added setuptools to test run deps (required by noxfile), since it's no longer installed by default with python 3.12 Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> * added setuptools as an explicit test dependency it is required in noxfile and not automatically provided by python >= 3.12 Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> * updated dependency spec of typing_extensions typing_extensions is currently required by all python versions Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> * updated autogen requirements files Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> --------- Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com>
* declared support for python 3.12 Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> * set python3.8 as min python in setup's 'python_requires' Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> * bumped pylint to <3.3 (3.2.x latest to be run with 3.8) Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> * added pyupgrade and applied modifications Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> * .github/tests: skipped pyspark tests on 3.12 Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> * TEMP: disabled pylint warnings (possibly-used-before-assignment). need addressing Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> * .github: added setuptools to test run deps (required by noxfile), since it's no longer installed by default with python 3.12 Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> * added setuptools as an explicit test dependency it is required in noxfile and not automatically provided by python >= 3.12 Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> * updated dependency spec of typing_extensions typing_extensions is currently required by all python versions Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> * updated autogen requirements files Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> --------- Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> Signed-off-by: Matt Richards <mrichards7@outlook.com.au>
* declared support for python 3.12 Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> * set python3.8 as min python in setup's 'python_requires' Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> * bumped pylint to <3.3 (3.2.x latest to be run with 3.8) Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> * added pyupgrade and applied modifications Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> * .github/tests: skipped pyspark tests on 3.12 Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> * TEMP: disabled pylint warnings (possibly-used-before-assignment). need addressing Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> * .github: added setuptools to test run deps (required by noxfile), since it's no longer installed by default with python 3.12 Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> * added setuptools as an explicit test dependency it is required in noxfile and not automatically provided by python >= 3.12 Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> * updated dependency spec of typing_extensions typing_extensions is currently required by all python versions Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> * updated autogen requirements files Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> --------- Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> Signed-off-by: Matt Richards <mrichards7@outlook.com.au>
* declared support for python 3.12 Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> * set python3.8 as min python in setup's 'python_requires' Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> * bumped pylint to <3.3 (3.2.x latest to be run with 3.8) Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> * added pyupgrade and applied modifications Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> * .github/tests: skipped pyspark tests on 3.12 Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> * TEMP: disabled pylint warnings (possibly-used-before-assignment). need addressing Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> * .github: added setuptools to test run deps (required by noxfile), since it's no longer installed by default with python 3.12 Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> * added setuptools as an explicit test dependency it is required in noxfile and not automatically provided by python >= 3.12 Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> * updated dependency spec of typing_extensions typing_extensions is currently required by all python versions Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> * updated autogen requirements files Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> --------- Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> Signed-off-by: Matt Richards <mrichards7@outlook.com.au>
* declared support for python 3.12 Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> * set python3.8 as min python in setup's 'python_requires' Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> * bumped pylint to <3.3 (3.2.x latest to be run with 3.8) Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> * added pyupgrade and applied modifications Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> * .github/tests: skipped pyspark tests on 3.12 Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> * TEMP: disabled pylint warnings (possibly-used-before-assignment). need addressing Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> * .github: added setuptools to test run deps (required by noxfile), since it's no longer installed by default with python 3.12 Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> * added setuptools as an explicit test dependency it is required in noxfile and not automatically provided by python >= 3.12 Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> * updated dependency spec of typing_extensions typing_extensions is currently required by all python versions Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> * updated autogen requirements files Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> --------- Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com>

pylint doesn't work becausev2.17.3won't install on 3.12updated pylint to 3.3, I ignored some warnings, and left some others that need proper addressingpossibly-used-before-assignment) in situ.distutils. But besides that, it works. As suggested, I excluded3.12xpysparkfrom the matrix.