Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python 3.8 support #1913

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

g-as
Copy link
Contributor

@g-as g-as commented Feb 18, 2025

No description provided.

@g-as g-as force-pushed the feature/remove_3.8 branch 2 times, most recently from 8558ddc to 75d343f Compare February 18, 2025 21:51
@cosmicBboy
Copy link
Collaborator

the ci error looks odd:

ImportError while loading conftest '/home/runner/work/pandera/pandera/tests/core/conftest.py'.
tests/core/conftest.py:4: in <module>
    from tests.core.checks_fixtures import (
tests/core/checks_fixtures.py:9: in <module>
    import pandera as pa
pandera/__init__.py:26: in <module>
    from pandera.api.pandas.array import SeriesSchema
pandera/api/pandas/array.py:15: in <module>
    from pandera.engines import pandas_engine
pandera/engines/pandas_engine.py:1216: in <module>
    class PydanticModel(DataType):
pandera/engines/pandas_engine.py:1219: in PydanticModel
    type: type[BaseModel] = dataclasses.field(default=None, init=False)  # type: ignore[assignment]
E   TypeError: 'Field' object is not subscriptable

@cosmicBboy
Copy link
Collaborator

btw @g-as I just merged #1916, which does away with the need for maintaining ci and dev requirements files. Also migrate to using uv as preferred package manager for development.

@g-as
Copy link
Contributor Author

g-as commented Feb 28, 2025

Alright. I'll rebase accordingly. Thanks for the heads-up.

@g-as g-as force-pushed the feature/remove_3.8 branch from 75d343f to cb86c29 Compare March 5, 2025 15:09
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 92.42902% with 24 lines in your changes missing coverage. Please review.

Project coverage is 81.53%. Comparing base (812b2a8) to head (b55becf).
Report is 204 commits behind head on main.

Files with missing lines Patch % Lines
pandera/api/dataframe/container.py 47.61% 11 Missing ⚠️
pandera/api/pyspark/model.py 82.60% 4 Missing ⚠️
pandera/api/dataframe/model.py 92.85% 2 Missing ⚠️
pandera/engines/pyarrow_engine.py 0.00% 2 Missing ⚠️
pandera/backends/pandas/container.py 88.88% 1 Missing ⚠️
pandera/backends/pyspark/container.py 80.00% 1 Missing ⚠️
pandera/engines/pandas_engine.py 88.88% 1 Missing ⚠️
pandera/typing/__init__.py 66.66% 1 Missing ⚠️
pandera/typing/fastapi.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1913       +/-   ##
===========================================
- Coverage   94.28%   81.53%   -12.75%     
===========================================
  Files          91      121       +30     
  Lines        7013     9387     +2374     
===========================================
+ Hits         6612     7654     +1042     
- Misses        401     1733     +1332     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@g-as g-as force-pushed the feature/remove_3.8 branch from 82cd0f8 to 2aa8f4a Compare March 5, 2025 20:54
g-as added 4 commits March 10, 2025 13:23

Verified

This commit was signed with the committer’s verified signature.
g-as Guillaume Andreu Sabater
Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com>

Verified

This commit was signed with the committer’s verified signature.
g-as Guillaume Andreu Sabater
Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com>

Verified

This commit was signed with the committer’s verified signature.
g-as Guillaume Andreu Sabater

Verified

This commit was signed with the committer’s verified signature.
g-as Guillaume Andreu Sabater
@g-as g-as force-pushed the feature/remove_3.8 branch from 2aa8f4a to b55becf Compare March 10, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants