Make Retry context manager not swallow exceptions #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any exception raised within the Retry context manager would just cause it to exit the code block without attempting to handle or reraise the error. This change makes the class raise HTTP 500/504 errors upon reaching max attempts, as well as reraising other exceptions, so they can be handled outside of the context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any exception raised within the Retry context manager would just cause it to exit the code block without attempting to handle or reraise the error. This led to failures later in codepaths assuming that all the lines ran in the context of the Retry instance had actually been executed.
This change makes the class raise HTTP 500/504 errors upon reaching max attempts, as well as reraising other exceptions, so they can be handled outside of the context.