-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SyncV2 protocol #5513
Merged
Merged
Add SyncV2 protocol #5513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8a69c3f
to
33c5981
Compare
33c5981
to
1df9974
Compare
db4fa74
to
691eaa9
Compare
5561503
to
f91dc10
Compare
88a37e0
to
55fd99b
Compare
ChrisPenner
commented
Jan 30, 2025
3acb723
to
aacd13a
Compare
aacd13a
to
d715063
Compare
1 task
aryairani
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds experimental (and hidden)
pull.v2
command which uses Share's SyncV2 protocol.Currently syncv2 is active on both staging and production :)
See caveats in Loose Ends below;
Usage:
Implementation notes
pull.v2
command which streams entities from Share rather than the current iterative deepening approach20s -> 15s
in total sync time for@unison/base/main
when statement caching was enabled;TODO: Check whether it's actually the statement caching or just the SQLite tuning that makes a difference here.; Yes it looks like statement caching does make a significat difference (14.5s -> 10s for a unison/base sync)pull
unaffected.Test coverage
I've tested it on staging and everything seems to be working, we'll probably get it running in Nimbus CI or something soon.
There are already some automated tests around the serialization format (from the sync-file PR)
Loose ends
There are several progressive enhancements I'm still working on, none of which should be breaking changes, but best to keep this command experimental for a short while :)