Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin awalsh128/[email protected] #5552

Merged
merged 2 commits into from
Jan 22, 2025
Merged

pin awalsh128/[email protected] #5552

merged 2 commits into from
Jan 22, 2025

Conversation

aryairani
Copy link
Contributor

@aryairani aryairani requested a review from a team as a code owner January 21, 2025 19:36
@aryairani
Copy link
Contributor Author

Sounds good. Do I need to do that everywhere? @ceedubs

@ceedubs
Copy link
Contributor

ceedubs commented Jan 22, 2025

@aryairani kind of your call. Pinning the hash reduces the risk of supply chain attack, so I generally think that it's a good idea. The only real downside that I know of is that it's a bit more manual work to update the action.

@aryairani
Copy link
Contributor Author

aryairani commented Jan 22, 2025

I see the https://github.com/mheap/pin-github-action tool, which rewrites your yaml for you, allows you to whitelist certain orgs (e.g. actions/) though I don't have a good sense of the likelihood that Github will be compromised before we are

@aryairani aryairani merged commit b83f2f7 into trunk Jan 22, 2025
32 checks passed
@aryairani aryairani deleted the aryairani-patch-4 branch January 22, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test jit ci step failing due to deprecated upload-artifact
3 participants