IndexedLDA/ADC/SBC optimization #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See #612 for more details. I'm accepting my coverage, here, because "compositional" rather than "casting" branches in this PR are well-tested in their exact current forms. With existing unit tests, we end up covering the new "casting" branches in this PR. So, our coverage has both types of branch, with "compositional" tested for a long time past, but I'm lumping due coverage for this PR into #612 for this weekend. |
|
I'm testing the 2-byte case, and this doesn't work, yet. WIP, for now. |
WrathfulSpatula
changed the title
|
Actually, this did work. I just didn't scale the Grover's test correctly, to exceed an 8-bit maximum width of the value register. The unit tests have been updated to reflect the correct approach. |
WrathfulSpatula
changed the title
|
Tested locally. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IndexedLDA()and variants are useful for Grover's search of a lookup table. Input tables are specified as byte pointers, composing words that are any multiple of 8 bits, (8, 16, 24, etc.). If the factors of 8 are powers of 2, then a static recasting of the input table pointer to native scalar pointer types avoids significant compositional costs.