feat: Build Stats #105
Open
feat: Build Stats #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We haven't been weekly for a while now
|
@MaxIsJoe is attempting to deploy a commit to the unitystation Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
move your stats bellow the heading of the page. I will check the components and stuff after work |
corp-0
reviewed
Apr 21, 2025
| @@ -14,7 +14,7 @@ const colourByType: Dict<string> = { | |||
|
|
|||
| const textByType: Dict<string> = { | |||
| 'announcement': 'Announcement', | |||
| 'weekly': 'Weekly Update', | |||
| 'weekly': 'Progress Update', | |||
There was a problem hiding this comment.
I think you forgot to rebase. This commmit already exists
corp-0
reviewed
Apr 21, 2025
| return ( | ||
| <Panel> | ||
| <h3 className="text-xl font-bold mb-4 text-white">Recent Build Statistics</h3> | ||
| <div className="grid grid-cols-1 md:grid-cols-3 gap-4"> |
There was a problem hiding this comment.
Suggested change
| <div className="grid grid-cols-1 md:grid-cols-3 gap-4"> | |
| <div className="grid grid-cols-1 lg:grid-cols-3 gap-4"> |
there is an awkward transition if you test how responsive is this new component where the 3 cols are not big enough for the text
corp-0
reviewed
Apr 21, 2025
| } | ||
|
|
||
| const BuildStatsComponent: React.FC<BuildStatsProps> = ({ builds }) => { | ||
| const recentBuilds = builds.slice(0, 150); |
corp-0
reviewed
Apr 21, 2025
| @@ -0,0 +1,68 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
all components should be inside the outer components folder.
I'd say this component is an organism, so place it inside components/organisms/changelog/
corp-0
reviewed
Apr 22, 2025
| @@ -0,0 +1,15 @@ | |||
| import React, { ReactNode } from 'react'; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a stats section at the top of the page that showcases how many additions, fixes and improvements were made in the past few builds + a card next to it that displays the latest code-scan version.