Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(UnoSDK): implicit package override #19383

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(UnoSDK): implicit package override #19383

wants to merge 2 commits into from
+3 −2

Conversation

ajpinedam
Copy link
Contributor

@ajpinedam ajpinedam commented Jan 30, 2025 •
edited
Loading

GitHub Issue (If applicable): closes https://github.com/unoplatform/add-private/issues/27

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Overriding MicrosoftLoggingVersion does not work on .NET9.

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@ajpinedam ajpinedam self-assigned this Jan 30, 2025
@ajpinedam ajpinedam requested a review from jeromelaban January 30, 2025 15:35
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19383/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19383/index.html

@ajpinedam
Copy link
Contributor Author

Fix proposed here is successfully overriding the package version

Before Fix After FIx
uno_before_fix_implicitoverride uno_fix_implicitoverride

@ajpinedam ajpinedam marked this pull request as ready for review January 30, 2025 20:26
@unodevops
Copy link
Contributor

⚠️⚠️ The build 153680 has failed on Uno.UI - CI.

@ajpinedam
Copy link
Contributor Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19383/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19383/index.html

@unodevops
Copy link
Contributor

⚠️⚠️ The build 154166 has failed on Uno.UI - CI.

@ajpinedam ajpinedam force-pushed the dev/ajpm/fix.implicitpackage.override branch from 498e984 to 3bce2dc Compare February 8, 2025 23:43
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19383/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19383/index.html

@unodevops
Copy link
Contributor

⚠️⚠️ The build 154554 has failed on Uno.UI - CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromelaban jeromelaban Awaiting requested review from jeromelaban

At least 1 approving review is required to merge this pull request.

Assignees

@ajpinedam ajpinedam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajpinedam @unodevops