Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify playbook compiler to flush handlers after each role. #1

Open
wants to merge 1 commit into
base: updox-2.8.5
Choose a base branch
from

Conversation

estheruary
Copy link

SUMMARY

A small change that I think will go completely unnoticed by people who don't care but make a big difference by people that do (i.e me).

The problem I run into is having to put awkward logic into roles that are used as dependencies because handlers are run too late.

# In dependent role.
install a new profile into /etc/supervisor.d
register a handler for supervisor to reload its config

# In main role.
start and enable the newly installed profile // error no such process

Yes it's a small annoyance but dammit this is how it should have worked from the beginning. There's a precedent for it too since handlers registered in pre_tasks are called before roles.

ISSUE TYPE
  • Feature Pull Request

@estheruary estheruary requested a review from amfranz December 11, 2019 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant