Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packmol tests #105

Merged
merged 6 commits into from
Mar 18, 2024
Merged

Packmol tests #105

merged 6 commits into from
Mar 18, 2024

Conversation

SamCox822
Copy link
Contributor

No description provided.

Jgmedina95
Jgmedina95 previously approved these changes Mar 6, 2024
@Jgmedina95 Jgmedina95 self-requested a review March 6, 2024 16:19
@Jgmedina95
Copy link
Contributor

Adding some tests on catching errors at the instructions. Example: Only one instruction, but two Molecules where passed. And vice-versa. Also, packmol handles different types of instructions. like centerofmass, center, etc... Some of them are not valid and are included in the validation of the inputs in the tool, so checking if this work correctly could be added.
A good one is if the validation can check if the pdb ids, are actually currently in the path registry to move forward or not.

FOr inspiration on the last item, in my PRs I did some of this :)

@Jgmedina95 Jgmedina95 dismissed their stale review March 6, 2024 16:22

I miss some stuff

@Jgmedina95
Copy link
Contributor

I see what you're doing here, and I like it! Need help fixing the errors at testing?

Copy link
Contributor

@Jgmedina95 Jgmedina95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SamCox822 SamCox822 merged commit d8fdc1b into main Mar 18, 2024
1 check passed
@SamCox822 SamCox822 deleted the packmol-tests branch March 18, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants