Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

94 making outlines prefilter #107

Merged
merged 15 commits into from
Mar 19, 2024
Merged

94 making outlines prefilter #107

merged 15 commits into from
Mar 19, 2024

Conversation

Jgmedina95
Copy link
Contributor

As described in the corresponding issue #93. Ive added a step to make structure and organize the user input into the prompt before it gets to the agent.

Ive included a lot of "#PR comments" to make it easier for review :)

Hre are some examples of how it works using only GPT-3.5-Turbo

agent.run("make a box of 0.1M of urea in water") 

Prompt: """        Approach the molecular dynamics inquiry by dissecting it into its modular
        components:
        Main Task: Simulate a box of 0.1M of urea in water
        Subtasks: Simulation, 
        Target Proteins: None
        Parameters: SaltConcentration: 0.1M, Solvate: True, 
        Initial Plan Proposed by User: None

        The Main Task is the user's request....."""
agent.run("Calculate the radius of gyration of 1A3N at 280K with water") 

prompt="""Approach the molecular dynamics inquiry by dissecting it into its modular
        components:
        Main Task: Calculate the radius of gyration of 1A3N at 280K with water
        Subtasks: Preprocessing, Simulation, Postanalysis, 
        Target Proteins: 1A3N, 
        Parameters: Temperature: 280K, Solvate: True, 
        Initial Plan Proposed by User: None

        The Main Task is the user's request...
...
..."""
agent.run("Calculate the Radial distribution function of 1A3N at 280K with water. Dont forget to preprocess the pdb file after downloading it") 
prompt="""
Approach the molecular dynamics inquiry by dissecting it into its modular
        components:
        Main Task: Calculate the Radial distribution function of 1A3N at 280K with water.
        Subtasks: Preprocessing, Simulation, Postanalysis, 
        Target Proteins: 1A3N, 
        Parameters: Temperature: 280K, Solvate: True, 
        Initial Plan Proposed by User: Download PDB file for 1A3N,Pre-process the PDB file,Calculate the Radial Distribution Function with water.,

        The Main Task is the user's ..."""

Important: Be sure to try it in a new environment, and install the dependencies from zero. As I had to fight a lot with dependencies conflicts and would like to see if the setup I came from creates other conflicts I haven't made aware yet.

@Jgmedina95 Jgmedina95 linked an issue Mar 12, 2024 that may be closed by this pull request
Copy link
Contributor

@SamCox822 SamCox822 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add tests for the reformat/query_filter? also - can you go ahead and remove the extra comments you made before approving? thanks!

@Jgmedina95 Jgmedina95 force-pushed the 94-Making-Outlines-Prefilter branch from 1803547 to 903b8b6 Compare March 18, 2024 15:39
@SamCox822 SamCox822 self-requested a review March 18, 2024 18:03
Copy link
Contributor

@qcampbel qcampbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Jgmedina95 Jgmedina95 merged commit 5e38213 into main Mar 19, 2024
1 check passed
@Jgmedina95 Jgmedina95 deleted the 94-Making-Outlines-Prefilter branch May 15, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Preprocess of User query before Agent Input
3 participants