Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update CreateNewTool to execute as well #62

Merged
merged 7 commits into from
Jan 10, 2024
Merged

update CreateNewTool to execute as well #62

merged 7 commits into from
Jan 10, 2024

Conversation

qcampbel
Copy link
Contributor

@qcampbel qcampbel commented Jan 3, 2024

  • partly combine CreateNewTool and ExecuteSkill, since it makes more sense to do it in one step instead of two.
  • renamed ExecuteSkill --> RetryExecuteSkill. Just in case executing fails (likely due to missing arguments). May remove this later if deemed unnecessary.

Jgmedina95
Jgmedina95 reviewed Jan 3, 2024
View reviewed changes
Copy link
Contributor

@Jgmedina95 Jgmedina95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment in maketools file

@Jgmedina95 Jgmedina95 self-requested a review January 10, 2024 19:06
Jgmedina95
Jgmedina95 reviewed Jan 10, 2024
View reviewed changes
Copy link
Contributor

@Jgmedina95 Jgmedina95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qcampbel qcampbel merged commit 8b61d6b into main Jan 10, 2024
1 check passed
@qcampbel qcampbel deleted the skilltools branch January 10, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jgmedina95 Jgmedina95 Jgmedina95 approved these changes

@SamCox822 SamCox822 Awaiting requested review from SamCox822

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qcampbel @Jgmedina95