Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pqa tool #91

Merged
merged 13 commits into from
Feb 27, 2024
Merged

Pqa tool #91

merged 13 commits into from
Feb 27, 2024

Conversation

SamCox822
Copy link
Contributor

No description provided.

This was linked to issues Feb 26, 2024
add literature search #96
Closed
Have md-agent use pqa to fill in parameters when applicable #27
Closed
Jgmedina95
Jgmedina95 reviewed Feb 27, 2024
View reviewed changes
Copy link
Contributor

@Jgmedina95 Jgmedina95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, i like the idea that we don't need a pqa API key anymore. My only question, not even a concern, is where is the function find_file_path used?

@SamCox822
Copy link
Contributor Author

Overall, i like the idea that we don't need a pqa API key anymore. My only question, not even a concern, is where is the function find_file_path used?

fixed this - thank you!

@SamCox822 SamCox822 requested a review from Jgmedina95 February 27, 2024 18:07
Jgmedina95
Jgmedina95 approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@Jgmedina95 Jgmedina95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SamCox822 SamCox822 merged commit 759b34e into main Feb 27, 2024
1 check passed
@SamCox822 SamCox822 deleted the pqa_tool branch February 27, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jgmedina95 Jgmedina95 Jgmedina95 approved these changes

@qcampbel qcampbel Awaiting requested review from qcampbel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add literature search Have md-agent use pqa to fill in parameters when applicable
2 participants
@SamCox822 @Jgmedina95