Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix live update and live activities on oldArch #602

Merged
merged 2 commits into from
Oct 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
# React Native Module Changelog

## Version 19.4.2 - October 22, 2024
Patch release to fix live activities and live updates on react old architecture and update Android and iOS SDK.

### Changes
- Fixed live activities and live updates on react old architecture.
- Updated Airship Android SDK to [18.3.3](https://github.com/urbanairship/android-library/releases/tag/18.3.3)
- Updated Airship iOS SDK to [18.11.1](https://github.com/urbanairship/ios-library/releases/tag/18.11.1)

## Version 19.4.1 - October 9, 2024
Patch release to fix a compile issue with the old Architecture on Android.

Expand Down
2 changes: 1 addition & 1 deletion android/gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ Airship_minSdkVersion=21
Airship_targetSdkVersion=34
Airship_compileSdkVersion=34
Airship_ndkversion=26.1.10909125
Airship_airshipProxyVersion=10.0.0
Airship_airshipProxyVersion=10.1.1
Original file line number Diff line number Diff line change
Expand Up @@ -713,36 +713,42 @@ class AirshipModule internal constructor(val context: ReactApplicationContext) :
}
}

@ReactMethod
override fun liveActivityListAll(promise: Promise) {
promise.resolveResult {
throw IllegalStateException("Not supported on Android")
}
}

@ReactMethod
override fun liveActivityList(request: ReadableMap?, promise: Promise) {
promise.resolveResult {
throw IllegalStateException("Not supported on Android")
}
}

@ReactMethod
override fun liveActivityStart(request: ReadableMap?, promise: Promise) {
promise.resolveResult {
throw IllegalStateException("Not supported on Android")
}
}

@ReactMethod
override fun liveActivityUpdate(request: ReadableMap?, promise: Promise) {
promise.resolveResult {
throw IllegalStateException("Not supported on Android")
}
}

@ReactMethod
override fun liveActivityEnd(request: ReadableMap?, promise: Promise) {
promise.resolveResult {
throw IllegalStateException("Not supported on Android")
}
}

@ReactMethod
override fun liveUpdateListAll(promise: Promise) {
promise.resolveSuspending(scope) {
proxy.liveUpdateManager.listAll().let {
Expand All @@ -751,6 +757,7 @@ class AirshipModule internal constructor(val context: ReactApplicationContext) :
}
}

@ReactMethod
override fun liveUpdateList(request: ReadableMap?, promise: Promise) {
promise.resolveSuspending(scope) {
proxy.liveUpdateManager.list(
Expand All @@ -761,6 +768,7 @@ class AirshipModule internal constructor(val context: ReactApplicationContext) :
}
}

@ReactMethod
override fun liveUpdateStart(request: ReadableMap?, promise: Promise) {
promise.resolveSuspending(scope) {
proxy.liveUpdateManager.start(
Expand All @@ -769,6 +777,7 @@ class AirshipModule internal constructor(val context: ReactApplicationContext) :
}
}

@ReactMethod
override fun liveUpdateUpdate(request: ReadableMap?, promise: Promise) {
promise.resolveSuspending(scope) {
proxy.liveUpdateManager.update(
Expand All @@ -777,6 +786,7 @@ class AirshipModule internal constructor(val context: ReactApplicationContext) :
}
}

@ReactMethod
override fun liveUpdateEnd(request: ReadableMap?, promise: Promise) {
promise.resolveSuspending(scope) {
proxy.liveUpdateManager.end(
Expand All @@ -785,6 +795,7 @@ class AirshipModule internal constructor(val context: ReactApplicationContext) :
}
}

@ReactMethod
override fun liveUpdateClearAll(promise: Promise) {
promise.resolveSuspending(scope) {
proxy.liveUpdateManager.clearAll()
Expand Down
44 changes: 22 additions & 22 deletions example/ios/Podfile.lock
Original file line number Diff line number Diff line change
@@ -1,25 +1,25 @@
PODS:
- Airship (18.10.0):
- Airship/Automation (= 18.10.0)
- Airship/Basement (= 18.10.0)
- Airship/Core (= 18.10.0)
- Airship/FeatureFlags (= 18.10.0)
- Airship/MessageCenter (= 18.10.0)
- Airship/PreferenceCenter (= 18.10.0)
- Airship/Automation (18.10.0):
- Airship (18.11.1):
- Airship/Automation (= 18.11.1)
- Airship/Basement (= 18.11.1)
- Airship/Core (= 18.11.1)
- Airship/FeatureFlags (= 18.11.1)
- Airship/MessageCenter (= 18.11.1)
- Airship/PreferenceCenter (= 18.11.1)
- Airship/Automation (18.11.1):
- Airship/Core
- Airship/Basement (18.10.0)
- Airship/Core (18.10.0):
- Airship/Basement (18.11.1)
- Airship/Core (18.11.1):
- Airship/Basement
- Airship/FeatureFlags (18.10.0):
- Airship/FeatureFlags (18.11.1):
- Airship/Core
- Airship/MessageCenter (18.10.0):
- Airship/MessageCenter (18.11.1):
- Airship/Core
- Airship/PreferenceCenter (18.10.0):
- Airship/PreferenceCenter (18.11.1):
- Airship/Core
- AirshipFrameworkProxy (10.0.0):
- Airship (= 18.10.0)
- AirshipServiceExtension (18.10.0)
- AirshipFrameworkProxy (10.1.1):
- Airship (= 18.11.1)
- AirshipServiceExtension (18.11.1)
- boost (1.83.0)
- DoubleConversion (1.1.6)
- FBLazyVector (0.73.4)
Expand Down Expand Up @@ -907,8 +907,8 @@ PODS:
- React-Mapbuffer (0.73.4):
- glog
- React-debug
- react-native-airship (19.4.1):
- AirshipFrameworkProxy (= 10.0.0)
- react-native-airship (19.4.2):
- AirshipFrameworkProxy (= 10.1.1)
- glog
- RCT-Folly (= 2022.05.16.00)
- React-Core
Expand Down Expand Up @@ -1279,9 +1279,9 @@ EXTERNAL SOURCES:
:path: "../node_modules/react-native/ReactCommon/yoga"

SPEC CHECKSUMS:
Airship: f05f63abc90b20274854a7cda3334f383af370cd
AirshipFrameworkProxy: 8bf84e8ca65c3847c63b6851463822f1a3fb2982
AirshipServiceExtension: b62830295737abaadc92572a1ec93175a749ea98
Airship: 208ebe5da07e89abee6c4abd14dfefa6aee14fa2
AirshipFrameworkProxy: 2a5c7331dfdfb5b04bcaa2072d7f7985c761c034
AirshipServiceExtension: e9e648c00eeeda6f0407c202998fc17b01955b77
boost: d3f49c53809116a5d38da093a8aa78bf551aed09
DoubleConversion: fea03f2699887d960129cc54bba7e52542b6f953
FBLazyVector: 84f6edbe225f38aebd9deaf1540a4160b1f087d7
Expand Down Expand Up @@ -1311,7 +1311,7 @@ SPEC CHECKSUMS:
React-jsinspector: 9ac353eccf6ab54d1e0a33862ba91221d1e88460
React-logger: 0a57b68dd2aec7ff738195f081f0520724b35dab
React-Mapbuffer: 63913773ed7f96b814a2521e13e6d010282096ad
react-native-airship: d8f5b6cd7f62135b13c31a5f2b2b4eb144819166
react-native-airship: 0fe02cd8f0489993fe75bc2a1cc07cb1a55d29d2
react-native-safe-area-context: b97eb6f9e3b7f437806c2ce5983f479f8eb5de4b
React-nativeconfig: d7af5bae6da70fa15ce44f045621cf99ed24087c
React-NativeModulesApple: 0123905d5699853ac68519607555a9a4f5c7b3ac
Expand Down
2 changes: 1 addition & 1 deletion ios/AirshipReactNative.swift
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public class AirshipReactNative: NSObject {
AirshipProxy.shared
}

public static let version: String = "19.4.1"
public static let version: String = "19.4.2"

private let eventNotifier = EventNotifier()

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@ua/react-native-airship",
"version": "19.4.1",
"version": "19.4.2",
"description": "Airship plugin for React Native apps.",
"main": "lib/commonjs/index",
"module": "lib/module/index",
Expand Down
2 changes: 1 addition & 1 deletion react-native-airship.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,6 @@ Pod::Spec.new do |s|
s.dependency "React-Core"
end

s.dependency "AirshipFrameworkProxy", "10.0.0"
s.dependency "AirshipFrameworkProxy", "10.1.1"

end
Loading