Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improvements to RLP encoding #2375

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from
Draft

feat: improvements to RLP encoding #2375

wants to merge 16 commits into from

Conversation

peterwht
Copy link
Contributor

wip

peterwht
peterwht commented Jan 24, 2025
View reviewed changes
integration-tests/public/rlp-cross-contract/lib.rs
let selector = keccak_selector(b"flip");
let callee: AccountId = callee.into();

// TODO: fails due to call builder encoding with scale
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more accurately, issue is coming from here:

ink/crates/env/src/engine/on_chain/impls/pallet_contracts.rs

Line 530 in ea20e21

let decoded = scale::DecodeAll::decode_all(&mut &output[..])?;

Base automatically changed from aj/rlp to master January 28, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmichi cmichi Awaiting requested review from cmichi cmichi will be requested when the pull request is marked ready for review cmichi is a code owner

@ascjones ascjones Awaiting requested review from ascjones ascjones will be requested when the pull request is marked ready for review ascjones is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@peterwht