-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use http-client-hints
#10
base: main
Are you sure you want to change the base?
Conversation
useRequestHeaders, | ||
} from '#imports' | ||
import { writeHeaders } from './headers' | ||
import { defineNuxtPlugin, useCookie, useRequestHeaders, useRuntimeConfig } from '#imports' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replace useRuntimeConfig
with useAppConfig
in all plugins and remove the registration from the configuration
So, the problem here is about adding an event handler to handle image requests. Dev server (playground):
Build + start SSR app via node (playground):
|
It is |
We can expose the utilities instead exposing a plugin, but then we're moving the problem to the consumer, I want to check it here with some minimal working example. |
/publish |
commit: |
Looks like we have problems with nitro cache headers event handler. I guess when vary header added the browser should change some http request headers. |
chore: cleanup playground chore: export server utils subpackage instead using nitro imports
Description
This PR also includes:
/cc @danielroe @pi0 no idea why it is not working (dev or build): I'll try tmr to move the repo to monorepo adding the playground to the workspaces.
Linked Issues
Additional Context
Tip
The author of this PR can publish a preview release by commenting
/publish
below.