experimental: resolve sitemap section from nav data #1544
+252
−290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request removes the standalone sitemapSections module and migrates sitemap configuration into the navigation YAML files to drive sitemap section behavior directly from the nav data.
- Removed the obsolete SitemapSection interface and related data.
- Added a sitemap configuration block (with keys such as section and parent) to both Japanese and English navigation files.
Reviewed Changes
Copilot reviewed 4 out of 8 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/data/sitemapSections.ts | Removed the outdated sitemapSections data and interface. |
| src/data/nav/ja.yml | Added sitemap configuration to relevant nav items for Japanese. |
| src/data/nav/en.yml | Added sitemap configuration to relevant nav items for English. |
Files not reviewed (4)
- src/components/pages/Sitemap.astro: Language not supported
- src/data/schemas/nav.json: Language not supported
- src/layouts/Footer/Navigation.astro: Language not supported
- src/layouts/Header/Navigation.astro: Language not supported
Comments suppressed due to low confidence (1)
src/data/sitemapSections.ts:1
- Ensure that all components or functions previously relying on the SitemapSection interface are now correctly using the nav YAML sitemap configuration, as this removal could lead to broken references.
export interface SitemapSection {
|
🚀 Deployed on https://deploy-preview-1544--utelecon.netlify.app |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
本当にこれでいいのか疑問が残るので draft です．