feat: add type_hash to rgbpp assets routes #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ShookLyngs
requested changes
Jul 3, 2024
Flouse
approved these changes
Jul 4, 2024
ShookLyngs
reviewed
Jul 4, 2024
| @@ -91,5 +91,6 @@ export const XUDTBalance = z.object({ | |||
| available_amount: z.string(), | |||
| pending_amount: z.string(), | |||
| type_hash: z.string(), | |||
| type_script: Script, | |||
There was a problem hiding this comment.
Another case issue is the Script is in camelCase where this type is in snake_case: https://github.com/ckb-cell/btc-assets-api/blob/f686bc1ab05719fc9942ecd01f1c1e645138cf9d/src/routes/rgbpp/types.ts#L3-L7
There was a problem hiding this comment.
- tracked in V2 API Checklist #185
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
type_scriptfield to/rgbpp/v1/address/:btc_address/balanceresponsetype_hashfield to/rgbpp/v1/assetsroutes response