chore(CI): archive the contract binaries to GitHub artifacts #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| - name: Archive the contract binaries ${{ github.sha }} | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: btc-spv-contract-binaries-${{ matrix.os }}-${{ github.sha }} |
There was a problem hiding this comment.
Unlike the official CKB contracts, SPV contracts are different when build in different environment.
Because:
- The official CKB contracts are built in dockers.
- Our contracts could be built with different environment, for example, Rust toolchain.
I think: for production environment, we have to define a build environment.
p.s. Rust 1.77.0 is released on March 21, 2024, but I used 1.76.0 to build contracts for test environment.
There was a problem hiding this comment.
Rust 1.77.0 is released on March 21
What about building a docker image with both Rust and LLVM, which could be used in a reproducible workflow?
And this image can be used by rgbpp contracts too.
Reference:
There was a problem hiding this comment.
What about building a docker image with both Rust and LLVM, ...
+1
chaoticlonghair
approved these changes
Mar 26, 2024
|
After discussion, will create a reproducible building workflow later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that a developer can download the contract binaries directly to a server and then run ckb-bitcoin-spv-service.