Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid duplicate connection #80

Merged
merged 2 commits into from
Jan 16, 2025
Merged

fix: avoid duplicate connection #80

merged 2 commits into from
Jan 16, 2025

Conversation

jjyr
Copy link
Collaborator

@jjyr jjyr commented Jan 15, 2025

  1. Save connection timestamps to pending_connections for better tracking of in-progress connections.
  2. Prevent reconnecting to the same peer within 5 seconds to avoid duplicate connection error.
  3. Clear pending_connections

@jjyr jjyr requested review from Flouse, yuche and EthanYuan January 15, 2025 15:12
@Flouse Flouse requested a review from duanyytop January 16, 2025 02:56
@Flouse Flouse added the enhancement New feature or request label Jan 16, 2025
@jjyr jjyr merged commit 85d7ca5 into develop Jan 16, 2025
9 checks passed
@jjyr jjyr deleted the avoid-duplicate-connection branch January 16, 2025 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duanyytop duanyytop duanyytop approved these changes

@EthanYuan EthanYuan EthanYuan approved these changes

@Flouse Flouse Awaiting requested review from Flouse

@yuche yuche Awaiting requested review from yuche

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jjyr @duanyytop @EthanYuan @Flouse