Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use sweep_target_address in spendable tx #82

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

EthanYuan
Copy link
Collaborator

@EthanYuan EthanYuan commented Jan 17, 2025

Passed to the mutiny lib using sweep_target_address, the mutiny node's background thread is automatically transferred to the target address when the channel is closed and some of the outputs satisfy the condition triggering the Event::SpendableOutputs event.

This eliminates the need to manually initiate a sweep tx and saves transaction fees.

For the caller, sweep_target_address in the MutinyWallet:: new parameter is similar to destination_address in MutinyWallet:: sweep_wallet, except for the additional Option wrapping. If None is passed, the behavior is the same as before.

@Flouse Flouse requested a review from Dawn-githup January 18, 2025 03:22
@jjyr jjyr merged commit 2302cc6 into utxostack:develop Jan 22, 2025
9 checks passed
@Flouse
Copy link

Flouse commented Jan 23, 2025

For the caller, sweep_target_address in the MutinyWallet:: new parameter is similar to destination_address in MutinyWallet:: sweep_wallet, except for the additional Option wrapping. If None is passed, the behavior is the same as before.

cc @ShookLyngs

@EthanYuan EthanYuan deleted the sweep-in-spendable-tx branch February 24, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants