-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: rework dokka generation #104
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #104 +/- ##
============================================
+ Coverage 89.31% 89.64% +0.32%
- Complexity 721 727 +6
============================================
Files 200 202 +2
Lines 4485 4568 +83
Branches 434 441 +7
============================================
+ Hits 4006 4095 +89
+ Misses 320 310 -10
- Partials 159 163 +4 ☔ View full report in Codecov by Sentry. |
e41b854
to
6137553
Compare
94aab67
to
f6c3dee
Compare
f6c3dee
to
ffcc45b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dokka isn't great, and documentation display is broken due to how fragile the hack around URLs here. It's probable that I was just doing something stupid, but in the mean time let's switch to Dokkatoo to get some nice(r) docs going on.
Edit: for future reference, I also had to disable "pretty URLs" from Netlify's config because it rewrites
/index.html
to/
and that breaks Dokka/DokkatooEdit2: As a bonus, add access to the Ktor
Application
instance inKtorApplication
and add a proper regression test on OpenAPI stuff