-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add matomo tracking #148
add matomo tracking #148
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
src/components/Landing/index.js
Outdated
@@ -6,6 +6,7 @@ import executeElm from "../../utils/executeELM"; | |||
import * as landingUtils from "./utility"; | |||
import { datishFormat } from "../../helpers/formatit"; | |||
import { | |||
addMamotoTracking, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@achen2401 it's Matomo, not Mamoto - can you please edit so it's easier to find :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @mcjustin for noticing the typo! I fixed it now.
src/helpers/utility.js
Outdated
@@ -707,3 +708,45 @@ export function dedupArrObjects(arr, key) { | |||
return acc; | |||
}, []); | |||
} | |||
|
|||
export function getMamotoTrackingSiteId() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@achen2401 another Mamoto gremlin here :) - and a call to it below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @mcjustin! This should be fixed too.
https://www.pivotaltracker.com/story/show/183594028
siteId from environment variable,
REACT_APP_MATOMO_SITE_ID
userId from parsed token response from session Storage:
parsed from token response