Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add matomo tracking #148

Merged
merged 7 commits into from
Dec 4, 2024
Merged

add matomo tracking #148

merged 7 commits into from
Dec 4, 2024

Conversation

achen2401
Copy link

@achen2401 achen2401 commented Oct 22, 2022

https://www.pivotaltracker.com/story/show/183594028

siteId from environment variable, REACT_APP_MATOMO_SITE_ID
userId from parsed token response from session Storage:

Screenshot 2024-12-04 at 11 24 12 AM

parsed from token response

@achen2401 achen2401 requested a review from mcjustin October 22, 2022 00:06
public/index.html Outdated Show resolved Hide resolved
public/index.html Outdated Show resolved Hide resolved
@achen2401 achen2401 closed this Sep 14, 2024
@achen2401 achen2401 reopened this Dec 4, 2024
@achen2401 achen2401 marked this pull request as draft December 4, 2024 03:48
@achen2401 achen2401 requested a review from ivan-c December 4, 2024 19:39
@achen2401 achen2401 marked this pull request as ready for review December 4, 2024 19:39
@achen2401 achen2401 requested a review from mcjustin December 4, 2024 19:40
Copy link
Member

@ivan-c ivan-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@@ -6,6 +6,7 @@ import executeElm from "../../utils/executeELM";
import * as landingUtils from "./utility";
import { datishFormat } from "../../helpers/formatit";
import {
addMamotoTracking,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@achen2401 it's Matomo, not Mamoto - can you please edit so it's easier to find :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @mcjustin for noticing the typo! I fixed it now.

@@ -707,3 +708,45 @@ export function dedupArrObjects(arr, key) {
return acc;
}, []);
}

export function getMamotoTrackingSiteId() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@achen2401 another Mamoto gremlin here :) - and a call to it below.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @mcjustin! This should be fixed too.

@achen2401 achen2401 merged commit 5360d12 into develop Dec 4, 2024
2 checks passed
@achen2401 achen2401 deleted the feature/matomo-tracking branch December 4, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants