Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle error when survey has not associated ELM lib #220

Merged
merged 3 commits into from
Dec 16, 2024
Merged

handle error when survey has not associated ELM lib #220

merged 3 commits into from
Dec 16, 2024

Conversation

achen2401
Copy link

@achen2401 achen2401 commented Dec 16, 2024 •
edited
Loading

per Slack convo

  • Allow more graceful handling of error when processing questionnaire ELM lib, i.e. use default lib as specified without raising exception.
  • Will not halt on exception anymore in FF
    Other fix:
  • minor styling fix of error display

@achen2401 achen2401 requested a review from mcjustin December 16, 2024 17:37
mcjustin
mcjustin reviewed Dec 16, 2024
View reviewed changes
src/utils/executeELM.js Outdated
)
.catch((e) => {
console.log("Error processing instrument ELM: ", e);
reject("rror processing instrument ELM. See console for details.");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@achen2401 little typo here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for catching that @mcjustin. Should be fixed now.

@achen2401 achen2401 merged commit 2874f62 into develop Dec 16, 2024
2 checks passed
@achen2401 achen2401 deleted the fixup/handle-survey-ELM-lib-error branch December 16, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcjustin mcjustin mcjustin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@achen2401 @mcjustin