Fix frontend API call error handling #238
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbugni
approved these changes
Feb 7, 2025
| export const HTTP_FORBIDDEN_STATUS_CODE = 403; | ||
| export const HTTP_UNAUTHORIZED_STATUS_CODE = 401; | ||
| export const FORBIDDEN_LOGOUT_URL = "/logout?forbidden=true"; | ||
| export const UNAUTHORIZED_LOGOUT_URL = "/logout?unauthorized=true"; |
There was a problem hiding this comment.
I'm fine with your approach, but perhaps any flavor of status_code would be more flexible and require less change? /logout?status_code=403
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see Slack convo here
User will be redirected and appropriate message will display if 403 error is raised. See screenshot:
