Merge pull request #61 from uwcirg/fix/MessageStatus-200-fix

MessageStatus change to 200

isacc_messaging/api/isacc_record_creator.py

@@ -308,7 +308,7 @@ def on_twilio_message_status_update(self, values):
                 extra={"message_sid": message_sid},
                 level='error'
             )
-            return f"{error}: {message_sid}"
+            raise IsaccTwilioError(f"ERROR! {error}: {message_sid}")
 
         cr = CommunicationRequest(cr)
         patient = resolve_reference(cr.recipient[0].reference)

isacc_messaging/api/views.py

@@ -97,9 +97,14 @@ def message_status_update():
     )
 
     record_creator = IsaccRecordCreator()
-    result = record_creator.on_twilio_message_status_update(request.values)
-    if result is not None:
-        return result, 500
+    try:
+        record_creator.on_twilio_message_status_update(request.values)
+    except Exception as ex:
+        audit_entry(
+            f"on_twilio_message_status_update generated error {ex}",
+            level='error'
+        )
+        return ex, 200
     return '', 204
 
 
@@ -149,7 +154,7 @@ def incoming_sms():
         audit_entry(
             f"on_twilio_message_received generated: {stackstr}",
             level="error")
-        return stackstr, 500
+        return stackstr, 200
     if result is not None:
         # Occurs when message is incoming from unknown phone 
         # or request is coming from a subscribed phone number, but